Replace global DI library functions with corresponding objects for PRS-4 compliance #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ooh, interesting... yeah sure, happy to change that so different autoloaders don't complain. Want me to do a quick 3.0.2 for it right away? Or do you want to have a look around and see if there's anything else you might want to update in the next week or so? |
|
I am good for now. I could not get my hosting service to work as a test for
me, but it is in prod now. So far, no issues.
…On Wed, May 1, 2024, 12:49 PM Zaahid Bateson ***@***.***> wrote:
Ooh, interesting... yeah sure, happy to change that so different
autoloaders don't complain.
Want me to do a quick 3.0.2 for it right away? Or do you want to have a
look around and see if there's anything else you might want to update in
the next week or so?
—
Reply to this email directly, view it on GitHub
<#238 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABYW6SZ4HJB6BUERYT656Y3ZAEMJHAVCNFSM6AAAAABHCAGZ2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYG42TIMBUGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the library fully PSR-4 compliant.
The php-di/php-di library supports global functions for various setup configurations. The problem is global functions are not PRS-4 compliant, so using a super fast and minimal memory footprint autoloader fails.
The solution is simple, use the corresponding classes called by the global functions. It turns out the php-di library does not use these global functions, and it is considered bad form to use global functions, as they are not PSR-4 compliant. Guzzle has recently depreciated global functions for example.