-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0 #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defaults to 'attaching' the stream, so fclose is called automatically, and requires the passed stream to stay open while Message is used.
Refactor PartStreamFilterManager into PartStreamContainer which keeps a part's streams and handles content stream conversions
Use static configuration so user classes can be instantiated more easily.
Parser message part factories use a specialized PartStreamContainer to keep the original message stream. Don't need separate MessageParts for parsed messages.
- Removes IMessage::getTextResourceHandle, IMessage::getHtmlResourceHandle - Removes IMessagePart::getContentResourceHandle
Document optional 'main' value portion for some parameter headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Use pimple/pimple for di, refactor initialization:
array of providers
Parser improvements:
won't parse all content/children and is therefore very very fast even on
larger messages)
message object is destroyed (or can be attached to the message)
Define and use interfaces instead of concrete classes for better
extensibility, change of internal hierarchy that didn't make sense
IUUEncodedPart instead of UUEncodedPart, IMultiPart is new, IMessage instead
of Message. HeaderPart and ParentHeaderPart no longer exist.
Remove deprecated resource handle methods:
IMessage::getHtmlResourceHandle
Filtering parts is now done with simple callbacks. PartFilter is now just a
convenience class with static methods that provides filtering callbacks
instead of a concrete class used for filtering.
Other minor changes of note:
'inline' or 'attachment' even if the header has a different value.