Skip to content

Commit

Permalink
Rename file w/ non-ascii characters, add test #88
Browse files Browse the repository at this point in the history
  • Loading branch information
zbateson committed Mar 26, 2019
1 parent 235b6e2 commit 63bedd7
Show file tree
Hide file tree
Showing 4 changed files with 35 additions and 5 deletions.
32 changes: 32 additions & 0 deletions tests/MailMimeParser/OnlyAsciiFileNamesTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<?php
namespace ZBateson\MailMimeParser;

use PHPUnit\Framework\TestCase;
use FilesystemIterator;
use RecursiveDirectoryIterator;
use RecursiveIteratorIterator;

/**
* Some 'unzip' utilities don't like non-ASCII characters appearing in file
* names. Created this test to prevent it from happening as it's happened more
* than once.
*
* @group Base
* @author Zaahid Bateson
*/
class OnlyAsciiFileNamesTest extends TestCase
{
public function testFileNames()
{
$dir = new RecursiveDirectoryIterator(dirname(__DIR__), FilesystemIterator::KEY_AS_PATHNAME | FilesystemIterator::SKIP_DOTS);
$iter = new RecursiveIteratorIterator($dir);
foreach ($iter as $f) {
$this->assertTrue(
mb_check_encoding($f->getFileName(), 'ASCII'),
$f->getFileName() . ' contains non-ascii characters, which may '
. 'cause problems with some \'unzip\' utilities when '
. 'installing via composer'
);
}
}
}
4 changes: 2 additions & 2 deletions tests/_data/emails/m0024.txt
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ Content-Transfer-Encoding: 7bit

------=_Part_12615_2070162380.1405958221094
Content-Type: application/msword;
name="=?UTF-8?Q?Biodiversit=C3=A9_de_semaine_en_semaine.doc?="
name="=?UTF-8?Q?Biodiversite_de_semaine_en_semaine.doc?="
content-transfer-encoding: base64
Content-Disposition: attachment; size=38078;
filename="=?UTF-8?Q?Biodiversit=C3=A9_de_semaine_en_semaine.doc?="
filename="=?UTF-8?Q?Biodiversite_de_semaine_en_semaine.doc?="

0M8R4KGxGuEAAAAAAAAAAAAAAAAAAAAAPgADAP7/CQAGAAAAAAAAAAAAAAABAAAAMQAAAAAAAAAA
EAAAMwAAAAEAAAD+////AAAAADAAAAD/////////////////////////////////////////////
Expand Down
4 changes: 1 addition & 3 deletions tests/phpunit.xml
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,7 @@
-->
<testsuites>
<testsuite name="Base">
<file>MailMimeParser/ContainerTest.php</file>
<file>MailMimeParser/MailMimeParserTest.php</file>
<file>MailMimeParser/MessageTest.php</file>
<directory suffix="Test.php">MailMimeParser</directory>
</testsuite>
<testsuite name="Message">
<directory suffix="Test.php">MailMimeParser/Message</directory>
Expand Down

0 comments on commit 63bedd7

Please sign in to comment.