Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google OAuth2 example #4371

Merged
merged 15 commits into from
Mar 13, 2025
Merged

Add Google OAuth2 example #4371

merged 15 commits into from
Mar 13, 2025

Conversation

frankvp11
Copy link
Contributor

Adds the Google OAuth2 example that I created here
Unfortunately, I'm not very skilled with readme's, so I used some images and text where I could. I ask that you guys fix that (if you feel it's necessary).
Let me know what you guys think.

@falkoschindler falkoschindler requested a review from rodja March 6, 2025 10:05
@falkoschindler falkoschindler added the documentation Type/scope: Documentation, examples and website label Mar 6, 2025
@falkoschindler falkoschindler added this to the 2.13 milestone Mar 6, 2025
@rodja
Copy link
Member

rodja commented Mar 9, 2025

@frankvp11 I finally found the time to spend some time on this PR. While your code worked I took the liberty to refactor and simplify it a bit. Please have a look and tell me what you think. Also it's interesting to compare it with the rework I've done to #3244, where I applied a lot of learnings from this PR.

@frankvp11
Copy link
Contributor Author

Glad to hear you were able to understand my code, and make use of it in your example as well. It looks a good bit cleaner now.

Copy link
Member

@rodja rodja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if we can get rid of the guide_images and simplify the README.md. @frankvp11 is there not a document at Google which describes the steps? I think it's much better if we do not need to maintain our own documentation. For one-tap-auth I found such a description:

# See https://developers.google.com/identity/gsi/web/guides/get-google-api-clientid#get_your_google_api_client_id.

Also the example should be added to https://github.com/zauberzeug/nicegui/blob/main/website/examples.py

@frankvp11
Copy link
Contributor Author

By the looks of it, that covers the exact same steps (this link, that you provided). I think it wouldn't be a bad idea to just remove the README and images all together and add the comment to the main.py itself.
What do you think?

@frankvp11
Copy link
Contributor Author

Were there any more updates required from my end?

@rodja rodja merged commit 729e714 into zauberzeug:main Mar 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Type/scope: Documentation, examples and website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants