-
-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce API to build Single Page Applications (SPAs) #2811
base: main
Are you sure you want to change the base?
Conversation
Integrated single page app into Client.open so navigation to SPA pages is redirected. Fixed bug with forward and backwards navigation between SPA pages. Collecting data from original pages to able to apply the original page title.
Integrated single page app into Client.open so navigation to SPA pages is redirected. Fixed bug with forward and backwards navigation between SPA pages. Collecting data from original pages to able to apply the original page title.
Fixed a bug which could occur when open was called before the UI was set up
…s registry in Client. General clean-up Added titles to sample app Added docu to SPA
4b89fb3
to
13f29ac
Compare
…the structure of the root page, the possibility to override the class and implement custom routing and to react to the creation of sessions. * Added samples for the single page router * Refactored the Login sample with the new possibilities and making use of Pydantic as an example for a cleaner code base
Thank you @Alyxion. There are a lot of interesting things in here. While you are right that a certain kind of applications my want to combine SPA and "per tab storage", it would make review and discussions simpler if you could create two separate pull requests for these features. |
…in the current Client instance - which in practice means "per browser tab".
Moved context import to top of the file
Added support for query and URL path parameters such as required by the modularization example. https://github.com/Alyxion/nicegui/blob/feature/client_data/examples/modularization/main.py works really like a charm now in regards of user experience when switching pages. At the moment it still throws a "Found top level layout element "Header" inside element "SinglePageRouterFrame". Top level layout elements should not be nested but must be direct children of the page content. This will be raising an exception in NiceGUI 1.5" warning due to the fact that it does not know yet that it actually is in the page content in that case. Update: Fixed the warning. PageLayout now also accepts the SPA root as valid parent for top level elements. |
Yes, we really want to merge this. I still need to find the time for another round of review. Especially we need to make a decision about the separation between view and outlet. |
Hi, i just wanted to state that i'm also really looking forward to this - but dont want to put pressure on you :) |
We are actually intensively testing this already with a larger user base in our company since a couple of weeks, overall it seems quite stable. We fond one minor bug (loosing query params when using the back button) which we will fix this week and sync again with the main branch. Also looking forward to see it branched as it enables some very neat features such as dynamic, volatile per-connection - practically "app instance" - data. |
# Conflicts: # nicegui/ui.py
…s now as well and does not loose the query information anymore.
I was checking this PR that maybe resolve my issue #4119 but I think that the documentation is not good enough as we have a new decorator |
# Conflicts: # nicegui/client.py
Thanks @Mte90 . Actually it is documented since a couple of weeks, see the commit message directly above your comment ;-), though some more detail and refinement would definitely not hurt. But due to r/l reasons very limited time resources. Just run the main.py of the PR to run the docu, you can find it in the Pages & Routing section. |
Thanks! I am not sure if with this feature it is possible to reference an element per user, at the end I implemented in this way #4119 (comment) |
Yes, it is. We are actually building a kinda complex SPA on it already with several different screens and many parallel users, no issues. Conceptual its like this: from nicegui import ui
from pydantic import BaseModel, Field
class User(BaseModel):
counter: int = Field(0, description="Count of times user clicked the button.")
class HomeScreen:
def __init__(self, user: User):
self.user = user
async def build(self):
ui.button("Click me").on_click(self.on_inc_button_click)
ui.link("Go to other page", other_page)
def on_inc_button_click(self):
self.user.counter += 1
ui.notification(f"You have clicked {self.user.counter} times.")
class OtherScreen:
def __init__(self, user: User):
self.user = user
async def build(self):
ui.label(f"Counter is currently at {self.user.counter}")
@ui.outlet("/")
def main_layout():
user = User() # actual code could e.g. try to fetch last session data from REDIS here.
with ui.header(fixed=True):
ui.label("Sample App")
yield {"user": user}
@main_layout.view("/")
async def home(user: User):
await HomeScreen(user).build()
@main_layout.view("/other")
async def other_page(user: User):
await OtherScreen(user).build()
ui.run() The outlet is run per user when he/she connects. There one can create per-user instance data. This data is then passed to individual page builders. On top of that we still synch the data w/ REDIS based upon the tab_id but that would exceed the sample here now. |
Cool so I am waiting for this PR to get approval and in meantime I will use what I developed. In the future we willrefactor for this :-D Maybe also a guide/doc about how to migrate a normal nicegui app to this new solution can be helpful to understand the differences. |
* Added the possibility to also use async functions to be used to define an outlet. * navigate.to now also supports view targets * Refactored the complex spa sample to be fully async * Refactored the auth spa example to be completely sync as counter example. * Bugfix: The authentication sample triggered a page reload on logout because it redirected to / rather than the login page. It now redirects to the login_view to auto-resolve the URL correctly
…not be part of the SPA and thus should be ignored.
Hi @Alyxion, I found a bit time to further look into the pull request. While by no means complete or well structured, I have some questions and remarks:
Also I still think we can simplify the API by allowing if inspect.iscoroutine(frame):
frame = await frame
if frame is None:
return # if outlet builder is not a generator, run_safe already added all content |
And some more question/remarks:
|
Hello Rodja, thank you for the the detailed review. I think many of the points you mentioned should be resolvable quite quickly, others will take some time. Will get back to your points next week. |
Hey, may be a little off-topic here, but regarding point 8 it might be helpful. And we run into navigation issues (buttons not working and so on) all the time if we don't put If you think it helps i can provide the corresponding error logs (Timeout errors from router mainly) and code snippets. |
Thank you @whoamiafterall . Actually the original SPA sample when I started this PR (meanwhile nearly a year ago) had some issues with the back button, though 4 months ago something has been patched. But its diverged soooo far to this PR now. Regarding the ui.context.client.connected(): My first guess is that if you wait for being connected, you can also be sure that the JavaScripts where loaded and thus the window.addEventListener("popstate", (event) is in place. This PR actually even enforces the ui.context.client.connected() under the hood so you at least would not have to add it to every method again. |
First of all sorry for the delay, but at the moment I'm quite busy. Thanks for your detailed review once again.
I just verified the code again, it should be correct. Before a navigation execution is actually executed first the callback is checked, than the "config" (ex "SinglePageRouterConfig", now Outlet, I just fixed that as well in the code). It defines the final path which is opened. All of this works fine for the test. It returns main and navigates there. If one runs the inner code as single app all also looks correct, will investigate further, may be just a missing sleep. UPDATE: Just verified the code, there is a check for the browser URL at the end of the check though the behavior currently does/shall just influence the internal routing defining "Which page shall be actually rendered", in theory it can even return content w/o an URL at all. For everything else the user can/should use
Becauuuuuuuse of this author ;-).... Just with the difference that we have an additional class layer in between now, but thats the origin. Of course we can rename it if desired.
I removed it, it actually had no effect anymore anyway as it continued at the end of the for-loop. There is still a bug though we need to keep in mind that if you actually really share a base path, e.g. ui.page(/my_target) is defined first and then an SPA is defined at / not all functions respect this yet such as navigate.to and rather than doing a real browser navigation they try to load the page as Outlet view.
Sure.
I think the name
As it refers living / arbritrary objects it can not be serealized. It could in theory me merged with the client_storage though, the lifetime is the same as both are connection bound.
Didnt work for me back then for several functions of the NiceCloud app, would need to be investigated, the inner functions failed then. Actually I still like the clean way of definitions between "this is a template" and "this is the actual content we store in the frame". |
After reviewing the code: Actually its always True if either a builder was assigned and/or the fragment.
Not for more complex applications, it can e.g. individualize the title, the fragment etc, the builder being called when using on_navigate. The name could / should be updated though and in general a cleanup might not hurt before merging it into main.
I have to reinvestigate. This PR is so aged mean-while but I think back then there we side effects if the client was not connected yet.
Yes, of course. Can not promise though when yet, quite intense releases ongoing atm and then two weeks offroad in the US, but for sure till end of March. |
NiceGUI is for us at Lechler a really awesome solution and step forward from Streamlit in regards of the visualization of live and streaming data as it puts the dev far more in control of which sub elements and page regions are updated when.
On the other hand it is still lacking three for us very crucial features Streamlit offers:
This (still work in progress) pull request tries to resolve at least most of the points above. It shall not yet resolve the situation that a user has an unstable internet connection and thus looses the connection to a server completely and needs to reconnect.
Persistent connection
In a scenario where you want to serve your NiceGUI solution not to hundreds of users there is after a certain point no way around scaling the solution over multiple processes, CPUs or over multiple servers.
If you need to load/keep alive large amounts of data per user w/o involving an external database this requires that the whole user session, even between page changes, is bound to one single process on one specific server. Streamlits uses a SPA approach here thus it creates a WebSockets connection once and all follow-up page and tab changes are just virtual thus changing the URL and browser history in the browser using pushstate but never really loading a new page using GET.
As discussed in the Add app.storage.tab or similar (1308) and in Discord there are several use cases where this is crucial to retain in-memory data on a "per session" basis, see below, which consequently requires that there is such a session in the first place.
Per tab storage
A data storage possibility per tab is cruicial to enable the user to create multiple app instances with different login credentials, configurations and views on a per tab basis. This is on purpose volatile so that user-credentials, critical business data etc. are gone once the browser tab was closed and the connection timed out. This shall match the current behavior of st.session_state.
In-memory storage of complex objects
The possibility to store living, non-JSON compatible objects such as Pandas tables, ML model weights etc. on a "per tab" basis and make them as easy accessible among different pages, global helper classes etc. as currently app.storage.user.
Update: Extracted the app.storage.session feature into a separate pull request 2820