Skip to content

export more JSON types #3202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

export more JSON types #3202

wants to merge 1 commit into from

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Jul 3, 2025

#3157 defined a bunch of typeddict classes for JSON types returned by zdtype.to_json() routines. Not all of those types were exported from the top-level dtype module, and thus not all of those types were available to the docs. This PR ensures that they are exported.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jul 3, 2025
@d-v-b d-v-b requested a review from jhamman July 3, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamman jhamman Awaiting requested review from jhamman

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@d-v-b