-
-
Notifications
You must be signed in to change notification settings - Fork 331
Array creation with strings for filters, serializer, compressors #2839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brokkoli71
wants to merge
33
commits into
zarr-developers:main
Choose a base branch
from
scalableminds:string-arguments-for-codecs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Array creation with strings for filters, serializer, compressors #2839
brokkoli71
wants to merge
33
commits into
zarr-developers:main
from
scalableminds:string-arguments-for-codecs
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brokkoli71
commented
Feb 18, 2025
brokkoli71
commented
Feb 18, 2025
normanrz
reviewed
Apr 7, 2025
d-v-b
reviewed
May 13, 2025
i think this is a good idea, and for codecs that have simple defaults (blosc and gzip and most conventional compressors), it's very user-friendly. but IMO we need to give users a very clear error when they use a string name for a codec that takes required parameters. |
…o string-arguments-for-codecs
@d-v-b what do you think of the updated error messages? |
# Conflicts: # tests/test_array.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
docs/user-guide/*.rst
changes/