Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the outdated twitter logo #105

Closed
wants to merge 2 commits into from
Closed

Changed the outdated twitter logo #105

wants to merge 2 commits into from

Conversation

AquibKhann
Copy link

closes #104

This pull request addresses the outdated Twitter logo issue by replacing it with a more current and visually consistent icon. The new Twitter icon has been sourced from a licensed and suitable provider to ensure compliance with project licensing requirements.

@sanketverma1704
Copy link
Member

Thanks for sending the PR, @AquibKhann.

Upon visiting https://zarr-developersgithubio--105.org.readthedocs.build/en/105/ and scrolling to the bottom, the Twitter (X) logo is not visible.

@AquibKhann
Copy link
Author

working on it

@AquibKhann
Copy link
Author

I have done the changes in the config.yml file but still the change is not being reflected. Did I need to make changes on some other files aswell ? can you please guide me .

@sanketverma1704
Copy link
Member

Maybe this will work: https://fontawesome.com/icons/x-twitter?f=brands&s=solid?

@AquibKhann
Copy link
Author

Thanks ! let me try

@AquibKhann
Copy link
Author

I am unable to setup the environment for running the Zarr on my machine due to some security constraint I will make it happen by tomorrow , can you tell me whether new PR make the changes visible or not .

@AquibKhann
Copy link
Author

??

@joshmoore
Copy link
Member

Not yet.
image

You can see the build under https://zarr-developersgithubio--105.org.readthedocs.build/en/105/ or by going to the job link:

image

@AquibKhann
Copy link
Author

We were not using the current Font-awesome version that is why we were not able to see the changes .

Zarr.-.Google.Chrome.2024-02-16.10-41-39.mp4

@sanketverma1704
Copy link
Member

Nice catch, @AquibKhann.
Do you wanna push the new changes?

@AquibKhann
Copy link
Author

I wanted to push but unfortunately I was not able to locate the file in which the CDN of Font Awesome is present .It might be hidden . Can you help me out ?

@AquibKhann
Copy link
Author

??

@sanketverma1704
Copy link
Member

I think you'd need to edit the _utilities.scss file to include the new version of logos.

In the minimal mistakes repo, I can only see the old versions of the Twitter logo (check here; the logos are this and this). This is why the new logos are not rendering properly.

Also, the zarr-developers.github.io repository doesn't fork the Minimal Mistakes repo. Instead, we're using the theme as a remote theme.
You can check out how to override theme defaults here and edit the _utilities.scss file to see if it works.

Let me know if there are more questions.

@AquibKhann AquibKhann closed this by deleting the head repository Feb 21, 2024
@AquibKhann
Copy link
Author

I was facing some issues to setup the environment so that I can run the site on my machine i.e why I deletd the fork and wanted to start from zero.

@AquibKhann
Copy link
Author

can you please help me out on how can I set up the environment on my machine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Outdated Twitter Logo in Zarr homepage
3 participants