Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor kerchunk fits reader #399

Closed
wants to merge 4 commits into from
Closed

Conversation

TomNicholas
Copy link
Member

Passes locally with zarr v2. But I think this will break for an env with zarr v3 in it.

  • Closes part of Vendor kerchunk readers? #377
  • Tests added
  • Tests passing
  • Full type hint coverage
  • Changes are documented in docs/releases.rst
  • New functions/methods are listed in api.rst
  • New functionality has documentation

@TomNicholas TomNicholas added Kerchunk Relating to the kerchunk library / specification itself dependencies Updates a dependency internals readers labels Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 123 lines in your changes missing coverage. Please review.

Project coverage is 71.23%. Comparing base (95fce11) to head (2433570).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
virtualizarr/vendor/kerchunk/fits.py 0.00% 83 Missing ⚠️
virtualizarr/vendor/kerchunk/codecs.py 0.00% 40 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (71.23%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
- Coverage   75.62%   71.23%   -4.40%     
==========================================
  Files          33       35       +2     
  Lines        1994     2117     +123     
==========================================
  Hits         1508     1508              
- Misses        486      609     +123     
Files with missing lines Coverage Δ
virtualizarr/vendor/kerchunk/codecs.py 0.00% <0.00%> (ø)
virtualizarr/vendor/kerchunk/fits.py 0.00% <0.00%> (ø)

@maxrjones maxrjones added the v3-migration Required for migration to Zarr-Python 3.0 label Jan 29, 2025
@TomNicholas
Copy link
Member Author

TomNicholas commented Jan 29, 2025

Note that in the kerchunk compatibility PR the FITS reader has now been updated to work with zarr-python v3. So we could just copy those changes here temporarily.

@maxrjones
Copy link
Member

maxrjones commented Jan 30, 2025

superseded by #406

@maxrjones maxrjones closed this Jan 30, 2025
@TomNicholas TomNicholas deleted the vendor_kerchunk_fits_reader branch February 4, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Updates a dependency internals Kerchunk Relating to the kerchunk library / specification itself readers v3-migration Required for migration to Zarr-Python 3.0
Projects
Development

Successfully merging this pull request may close these issues.

2 participants