Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ab/upgrade icechunk #378

Closed
wants to merge 2 commits into from
Closed

Ab/upgrade icechunk #378

wants to merge 2 commits into from

Conversation

abarciauskas-bgse
Copy link
Collaborator

Just opening this as a draft PR to share the changes I implemented to get icechunk>=0.1.0a10 to work.

I believe we will need a more complete redesign and refactor of how we're handling codecs and zarr-python 3.0 integration across the codebase.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.75%. Comparing base (908ad94) to head (079e480).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
virtualizarr/zarr.py 14.28% 6 Missing ⚠️
virtualizarr/codecs.py 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (12.50%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
- Coverage   79.11%   78.75%   -0.37%     
==========================================
  Files          32       32              
  Lines        1906     1911       +5     
==========================================
- Hits         1508     1505       -3     
- Misses        398      406       +8     
Files with missing lines Coverage Δ
virtualizarr/writers/icechunk.py 0.00% <ø> (ø)
virtualizarr/codecs.py 60.00% <0.00%> (ø)
virtualizarr/zarr.py 72.47% <14.28%> (-2.53%) ⬇️

... and 2 files with indirect coverage changes

@rabernat
Copy link
Collaborator

Just wanted to note that I successfully used this branch to create an Icechunk virtual dataset for GPM IMERG with Icechunk 0.1.0.a12. 🙌

@abarciauskas-bgse
Copy link
Collaborator Author

Closing in favor of #406

@TomNicholas TomNicholas deleted the ab/upgrade-icechunk branch February 4, 2025 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3-migration Required for migration to Zarr-Python 3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants