Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Minor improvements.

Signed-off-by: Madelyn Olson <[email protected]>
  • Loading branch information
madolson authored Oct 15, 2024
1 parent c235d93 commit ef6a217
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion deps/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ and our version:
1. Makefile is modified to allow a different compiler than GCC.
2. We have the implementation source code, and directly link to the following external libraries: `lua_cjson.o`, `lua_struct.o`, `lua_cmsgpack.o` and `lua_bit.o`.
3. There is a security fix in `ldo.c`, line 498: The check for `LUA_SIGNATURE[0]` is removed in order to avoid direct bytecode execution.
4. In lstring.c, the luaS_newlstr function's hash calculation has been upgraded from a simple hash function to MurmurHash3, implemented within the same file, to enhance performance, particularly for operations involving large strings.
4. In `lstring.c`, the luaS_newlstr function's hash calculation has been upgraded from a simple hash function to MurmurHash3, implemented within the same file, to enhance performance, particularly for operations involving large strings.

Hdr_Histogram
---
Expand Down
2 changes: 1 addition & 1 deletion deps/lua/src/lstring.c
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ uint32_t murmur32(const uint8_t* key, size_t len, uint32_t seed) {
static const uint32_t r2 = 13;
static const uint32_t m = 5;
static const uint32_t n = 0xe6546b64;
uint32_t hash = seed; // static seed
uint32_t hash = seed;

const int nblocks = len / 4;
const uint32_t* blocks = (const uint32_t*) key;
Expand Down

0 comments on commit ef6a217

Please sign in to comment.