Skip to content

Conversation

@aronowski
Copy link
Contributor

No description provided.

@m-iwanicki m-iwanicki self-requested a review October 7, 2025 12:16
Copy link
Contributor

@m-iwanicki m-iwanicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for amdtool before my re-review

@aronowski aronowski force-pushed the amdtool branch 3 times, most recently from fc929f0 to 04359b9 Compare October 9, 2025 11:55
Copy link
Contributor

@m-iwanicki m-iwanicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format commit msg correctly:

recipes-bsp: coreboot-utils: amdtool_git.bb: add amdtool
+
recipes-bsp: coreboot-utils: files: coreboot-amdtool.patch: add patch
recipes-bsp: packagegroups: packagegroup-coreboot-utils.bb: add amdtool
.codespellrc: exclude coreboot-amdtool.patch, so that the change
https://review.coreboot.org/q/I34405897d0f5670038e7923f3680a28090d92821
is used as-is, without reformatting.

Signed-off-by: Kamil Aronowski <[email protected]>

There needs to be empty line between header and body.
Also reword it, no need to mention every file you added.
Maybe:

recipes-bsp: coreboot-utils: add amdtool recipe

recipes-bsp: packagegroup-coreboot-utils: add amdtool
.codespellrc: exclude coreboot-amdtool.patch so pre-commit
doesn't try to fix `.patch` file

@aronowski aronowski force-pushed the amdtool branch 2 times, most recently from 5ce8039 to bac417c Compare October 9, 2025 12:23
@aronowski aronowski force-pushed the amdtool branch 4 times, most recently from 50a7103 to d188f53 Compare October 9, 2025 13:18
@aronowski aronowski marked this pull request as ready for review October 9, 2025 13:28
@aronowski
Copy link
Contributor Author

Current issues addressed, commit message fixed.

@aronowski aronowski requested a review from m-iwanicki October 9, 2025 13:29
recipes-bsp: packagegroup-coreboot-utils: add amdtool
.codespellrc: exclude coreboot-amdtool.patch so pre-commit
doesn't try to fix `.patch` file

Signed-off-by: Kamil Aronowski <[email protected]>
Copy link
Contributor

@m-iwanicki m-iwanicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On QEMU:

bash-5.2# amdtool
Not an AMD southbridge.
bash-5.2# amdtool -h
usage: amdtool [-vh?gicspGlMAa]

   -v | --version:                   print the version
   -h | --help:                      print this help

   -s | --spi:                       dump southbridge spi and bios_cntrl registers
   -g | --gpio:                      dump southbridge GPIO registers
   -G | --gpio-diffs:                show GPIO differences from defaults
   -i | --irq-routing                dump IRQ routing registers
   -l | --lpc:                       dump southbridge LPC/eSPI Interface registers

   -c | --cpu:                       dump CPU information and features

   -M | --msrs:                      dump CPU MSRs
   -A | --acpimmio:                  dump southbridge ACPI MMIO registers
   -p | --psb:                       dump Platform Secure Boot state
   -a | --all:                       dump all known (safe) registers

bash-5.2# amdtool -v
amdtool v0.1 -- Copyright (C) 2024 3mdeb

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, version 2 of the License.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.

On PC Engines APU6:

bash-5.2# amdtool
CPU: ID 0x730f01, Processor Type 0x0, Family 0x16, Model 0x30, Stepping 0x1
Northbridge: 1022:1566 (unknown)
Southbridge SMBus: 1022:780b rev 42 (FCH SMBus Controller)
Southbridge LPC: 1022:780e rev 11 (FCH LPC Bridge)

bash-5.2# amdtool -c
(...)
CPU brand string: AMD GX-412TC SOC

============= AMD CPU features =============
SVM supported             : YES
SKINIT supported          : YES
====================================================
(...)

@aronowski aronowski changed the title WIP: Add amdtool Add amdtool Oct 9, 2025
@m-iwanicki m-iwanicki merged commit c8254de into main Oct 10, 2025
1 check passed
@m-iwanicki m-iwanicki deleted the amdtool branch October 10, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants