ascanrules: Oracle SQLi use DBMS_SESSION.SLEEP #6630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingthorin
commented
Jul 28, 2025
...les/src/main/java/org/zaproxy/zap/extension/ascanrules/SqlInjectionOracleTimingScanRule.java
Outdated
Show resolved
Hide resolved
kingthorin
commented
Jul 28, 2025
...les/src/main/java/org/zaproxy/zap/extension/ascanrules/SqlInjectionOracleTimingScanRule.java
Outdated
Show resolved
Hide resolved
kingthorin
commented
Jul 28, 2025
...les/src/main/java/org/zaproxy/zap/extension/ascanrules/SqlInjectionOracleTimingScanRule.java
Outdated
Show resolved
Hide resolved
|
Why use it at all in insane? |
|
Great job! No new security vulnerabilities introduced in this pull requestUse @Checkmarx to reach out to us for assistance. Just send a PR comment with Examples: |
You mean use only the expensive one at insane? I hadn't put any thought into it. However, now that you've brought it up: Simply because of the length (character count) of the "expensive" version and shouldn't we be increasing the coverage/payloads not trying something totally different? (I think most other places we do more and more, not switch completely) Or have I totally missed your question? |
|
I mean remove the pseudo expensive. |
kingthorin
force-pushed
the
oracle-sleep
branch
3 times, most recently
from
5bf50cb to
10cc765
Compare
kingthorin
force-pushed
the
oracle-sleep
branch
2 times, most recently
from
a0acbe4 to
6a2092b
Compare
thc202
reviewed
Sep 15, 2025
thc202
reviewed
Sep 15, 2025
...test/java/org/zaproxy/zap/extension/ascanrules/SqlInjectionOracleTimingScanRuleUnitTest.java
Outdated
Show resolved
Hide resolved
kingthorin
force-pushed
the
oracle-sleep
branch
from
6a2092b to
c285b4a
Compare
|
Done & done |
thc202
reviewed
Sep 15, 2025
...les/src/main/java/org/zaproxy/zap/extension/ascanrules/SqlInjectionOracleTimingScanRule.java
Outdated
Show resolved
Hide resolved
...les/src/main/java/org/zaproxy/zap/extension/ascanrules/SqlInjectionOracleTimingScanRule.java
Outdated
Show resolved
Hide resolved
...les/src/main/java/org/zaproxy/zap/extension/ascanrules/SqlInjectionOracleTimingScanRule.java
Outdated
Show resolved
Hide resolved
...les/src/main/java/org/zaproxy/zap/extension/ascanrules/SqlInjectionOracleTimingScanRule.java
Outdated
Show resolved
Hide resolved
...les/src/main/java/org/zaproxy/zap/extension/ascanrules/SqlInjectionOracleTimingScanRule.java
Outdated
Show resolved
Hide resolved
|
There's still #6630 (comment) |
kingthorin
force-pushed
the
oracle-sleep
branch
from
c285b4a to
0b73b61
Compare
|
Got all those I think. |
thc202
reviewed
Sep 15, 2025
...les/src/main/java/org/zaproxy/zap/extension/ascanrules/SqlInjectionOracleTimingScanRule.java
Outdated
Show resolved
Hide resolved
kingthorin
force-pushed
the
oracle-sleep
branch
3 times, most recently
from
7cff8f3 to
9fadf75
Compare
Signed-off-by: kingthorin <[email protected]>
kingthorin
force-pushed
the
oracle-sleep
branch
from
9fadf75 to
d871a7a
Compare
thc202
approved these changes
Sep 16, 2025
|
Thank you! |
psiinon
approved these changes
Sep 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The SQL Injection - Oracle (Time Based) rule now uses DBMS_SESSION.SLEEP instead of an "expensive" query.
Related Issues