Fix build for c++ 20 #1060
Open
Fix build for c++ 20 #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zaphoyd, +1 for merging this. |
|
@zaphoyd do you plan to merge and create a new tag for that change ? Thank you in advance |
|
Just as a heads up, the https://github.com/zaphoyd/websocketpp/tree/develop branch already has this fix since 3197a52 |
|
Cool, thanks. Any thoughts, when this can be released and be available in conan center? Ofk there is a way to use the |
|
@selevit I think your best bet would be to submit a patch to the conan-center repo https://github.com/conan-io/conan-center-index/tree/master/recipes/websocketpp to fix builds for C++20 similar to how the vcpkg folks did it microsoft/vcpkg#23669 |
Sil3ntStorm
added a commit
to Sil3ntStorm/websocketpp
that referenced
this pull request
Dec 28, 2022
|
@pajlada oh, cool, thanks for the suggestion and the link |
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Nov 4, 2023
websocketpp had some ill-formed usage of template parameters which was finally removed in C++20. Hence build fails when building with C++20 support enabled. The patch is already in the develop branch but no new release was done. There are no autobuilder failures because websocketpp is a header-only library, and there are no packages in Buildroot that depned on websocketpp. A build issue was encountered when bumping an internal project to C++20. This issue triggered quite some bug reports in the project [0] and there are backports to other package managers like vcpkg [1] and conan [2]. [0] zaphoyd/websocketpp#1060 [1] microsoft/vcpkg#23669 [2] conan-io/conan-center-index#15295 Signed-off-by: Michael Nosthoff <[email protected]> [Thomas: extend commit log with details provided by Michael.] Signed-off-by: Thomas Petazzoni <[email protected]>
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Nov 8, 2023
websocketpp had some ill-formed usage of template parameters which was finally removed in C++20. Hence build fails when building with C++20 support enabled. The patch is already in the develop branch but no new release was done. There are no autobuilder failures because websocketpp is a header-only library, and there are no packages in Buildroot that depned on websocketpp. A build issue was encountered when bumping an internal project to C++20. This issue triggered quite some bug reports in the project [0] and there are backports to other package managers like vcpkg [1] and conan [2]. [0] zaphoyd/websocketpp#1060 [1] microsoft/vcpkg#23669 [2] conan-io/conan-center-index#15295 Signed-off-by: Michael Nosthoff <[email protected]> [Thomas: extend commit log with details provided by Michael.] Signed-off-by: Thomas Petazzoni <[email protected]> (cherry picked from commit 9ac1a76) Signed-off-by: Peter Korsgaard <[email protected]>
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Nov 8, 2023
websocketpp had some ill-formed usage of template parameters which was finally removed in C++20. Hence build fails when building with C++20 support enabled. The patch is already in the develop branch but no new release was done. There are no autobuilder failures because websocketpp is a header-only library, and there are no packages in Buildroot that depned on websocketpp. A build issue was encountered when bumping an internal project to C++20. This issue triggered quite some bug reports in the project [0] and there are backports to other package managers like vcpkg [1] and conan [2]. [0] zaphoyd/websocketpp#1060 [1] microsoft/vcpkg#23669 [2] conan-io/conan-center-index#15295 Signed-off-by: Michael Nosthoff <[email protected]> [Thomas: extend commit log with details provided by Michael.] Signed-off-by: Thomas Petazzoni <[email protected]> (cherry picked from commit 9ac1a76) Signed-off-by: Peter Korsgaard <[email protected]>
|
what fuck this BUG? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.