Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: better support different number of rings #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: better support different number of rings #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions docs/radar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ function radar_visualization(config) {
y: 15 * quadrants[quadrant].factor_y
};
var cartesian_max = {
x: rings[3].radius * quadrants[quadrant].factor_x,
y: rings[3].radius * quadrants[quadrant].factor_y
x: rings[rings.length - 1].radius * quadrants[quadrant].factor_x,
y: rings[rings.length - 1].radius * quadrants[quadrant].factor_y
};
return {
clipx: function(d) {
Expand Down Expand Up @@ -157,7 +157,7 @@ function radar_visualization(config) {
var segmented = new Array(4);
for (var quadrant = 0; quadrant < 4; quadrant++) {
segmented[quadrant] = new Array(4);
for (var ring = 0; ring < 4; ring++) {
for (var ring = 0; ring < rings.length; ring++) {
segmented[quadrant][ring] = [];
}
}
Expand All @@ -169,7 +169,7 @@ function radar_visualization(config) {
// assign unique sequential id to each entry
var id = 1;
for (var quadrant of [2,3,1,0]) {
for (var ring = 0; ring < 4; ring++) {
for (var ring = 0; ring < rings.length; ring++) {
var entries = segmented[quadrant][ring];
entries.sort(function(a,b) { return a.label.localeCompare(b.label); })
for (var i=0; i<entries.length; i++) {
Expand Down Expand Up @@ -307,7 +307,7 @@ function radar_visualization(config) {
.style("font-family", "Arial, Helvetica")
.style("font-size", "18px")
.style("font-weight", "bold");
for (var ring = 0; ring < 4; ring++) {
for (var ring = 0; ring < rings.length; ring++) {
legend.append("text")
.attr("transform", legend_transform(quadrant, ring))
.text(config.rings[ring].name)
Expand Down