test: skipper basic startup routes file, inlinecontent, status checks… #2115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, .. Signed-off-by: Sandor Szücs <[email protected]>
|
👍 |
1 similar comment
|
👍 |
| @@ -23,6 +23,7 @@ import ( | |||
| "github.com/zalando/skipper/filters/auth" | |||
| "github.com/zalando/skipper/filters/builtin" | |||
| fscheduler "github.com/zalando/skipper/filters/scheduler" | |||
| "github.com/zalando/skipper/innkeeper" | |||
There was a problem hiding this comment.
Should we rather deprecate this?
There was a problem hiding this comment.
It's already since long time, but I need to use to to create the default data clients. I can refactor the code to drop it from test, but I don't really care for now.
Comment on lines
+736
to
+757
| // create LB in front of apiservers to be able to switch the data served by apiserver | ||
| ro := routing.Options{ | ||
| SignalFirstLoad: true, | ||
| FilterRegistry: fr, | ||
| DataClients: dcs, //[]routing.DataClient{dc}, | ||
| PostProcessors: []routing.PostProcessor{ | ||
| loadbalancer.NewAlgorithmProvider(), | ||
| reg, | ||
| }, | ||
| SuppressLogs: true, | ||
| } | ||
| rt := routing.New(ro) | ||
| defer rt.Close() | ||
| <-rt.FirstLoad() | ||
| tracer := &tracingtest.Tracer{} | ||
| pr := proxy.WithParams(proxy.Params{ | ||
| Routing: rt, | ||
| OpenTracing: &proxy.OpenTracingParams{Tracer: tracer}, | ||
| }) | ||
| defer pr.Close() | ||
| lb := stdlibhttptest.NewServer(pr) | ||
| defer lb.Close() |
There was a problem hiding this comment.
I saw a flake
--- FAIL: TestDataClients (1.01s)
skipper_test.go:527: Waiting for proxy being ready
skipper_test.go:527: Waiting for proxy being ready
skipper_test.go:527: Waiting for proxy being ready
skipper_test.go:527: Waiting for proxy being ready
skipper_test.go:527: Waiting for proxy being ready
skipper_test.go:527: Waiting for proxy being ready
skipper_test.go:527: Waiting for proxy being ready
skipper_test.go:527: Waiting for proxy being ready
skipper_test.go:527: Waiting for proxy being ready
skipper_test.go:527: Waiting for proxy being ready
skipper_test.go:538: Failed to GET routes file route: Get "http://localhost:8090/routes-file": dial tcp 127.0.0.1:8090: connect: connection refused
TBH I can not understand what this is testing.
There was a problem hiding this comment.
That skipper starts with dataclients and safety nets enabled like status check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: skipper basic startup routes file, inlinecontent, status checks…
Signed-off-by: Sandor Szücs [email protected]