Check cluster UID#3019
Draft
mikkeloscar wants to merge 4 commits into
Draft
Conversation
mikkeloscar
force-pushed
the
check-cluster-UID
branch
5 times, most recently
from
e0417c9 to
140f6be
Compare
mikkeloscar
force-pushed
the
check-cluster-UID
branch
from
140f6be to
fdbdbd4
Compare
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
mikkeloscar
force-pushed
the
check-cluster-UID
branch
from
e3921f8 to
47de378
Compare
FxKu
reviewed
Jul 2, 2026
| c.clustersMu.RLock() | ||
| cl, clusterFound := c.clusters[clusterName] | ||
| if clusterFound && cl.UID != clusterUID { | ||
| clusterFound = false |
Contributor
There was a problem hiding this comment.
I think this will lead to an error during deletion, see
Must be the reason why e2e tests always fail with the cluster deletion test (if they even get there)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In situations where an existing Postgresql cluster is deleted and a new cluster, with the same name, is created, then the operator can get "confused" because it still holds the internal state of the previous cluster.
To avoid operating on the old state, check if the UID matches and mark the cluster as not found if it doesn't.