fix: no jittering with "round" commit strategy #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: make round the default commit box strategy - fix jiggling by using a remainder and updating size by whole numbers - move files and fix label - choose typescript version compatible with eslint
Deploying with
|
| Latest commit: |
6ef2312
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d5ea4564.react-roi.pages.dev |
| Branch Preview URL: | https://resize-jiggling.react-roi.pages.dev |
targos
reviewed
Mar 11, 2024
|
@targos Do you think the level of jittering is now acceptable? I don't really have ideas left to improve it. What I like about the change is that during resize, the change in size appears in whole width / height increments (try a very large zoom to see it) This limits how much the the ROI changes once the user finishes the resize action |
targos
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #132
This does not completely solve the issue but improves it by a lot.