allow type declarations in tasks and functions #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IEEE Std 1800-2023 has the following structural hierarchy: 1. A.2.6 Function declarations and A.2.7 Task declarations 2. A.2.8 Block item declarations 3. A.2.1.3 Type declarations Therefore, type declarations can be placed inside task and function declarations.
zachjs
reviewed
Nov 2, 2025
| %error { parseErrorTok } | ||
|
|
||
| %expect 0 | ||
| %expect 4 |
Owner
There was a problem hiding this comment.
It looks like this introduces shift/reduce conflicts, meaning there is ambiguity in the grammar. I'm going to see if there is a way to add this feature without the conflicts.
zachjs
approved these changes
Nov 2, 2025
Owner
zachjs
left a comment
zachjs
left a comment
There was a problem hiding this comment.
I believe I fixed the shift/reduce conflict. Can you please take a look and see if it still works for your use case?
Author
The change looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IEEE Std 1800-2023 has the following structural hierarchy:
Therefore, type declarations can be placed inside task and function declarations.