Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create strings.xml #1722

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Create strings.xml #1722

wants to merge 1 commit into from

Conversation

Mickael81
Copy link

French translation for InnerTune

French translation for InnerTune
@lucasmz-dev
Copy link
Contributor

I see you already had these in Weblate, any reason you're opening a PR? These should land next update.

@Mickael81
Copy link
Author

Hello,
Thanks for your feedback.
I improved the translation of InnerTune using Weblate as you told me. I opened a PR if needed. If you don't need it, I'll delete it.
According to the projects published on GitHub, some prefer a PR, others use Weblate and others Crowdin.
I didn't know if my contribution had been taken into account.

@lucasmz-dev
Copy link
Contributor

InnerTune had a hidden Crowdin I wasn't aware of for a while, no contributions there have landed unfortunately, though I didn't see much activity either

Weblate works now and that's the preferred way, PRs are "fine" but in the event that there's modifications both in Weblate and a PR, we ultimately can't know which one to prefer when collisions happen

There's a PR for Weblate translations, it should contain these already

@Mickael81
Copy link
Author

I understand. Thank you for these explanations. From now on I will use Weblate to correct and improve the translation of the application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants