Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligned CD train-test functionality #624

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

KulikDM
Copy link
Contributor

@KulikDM KulikDM commented Feb 1, 2025

All Submissions Basics:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you checked all Issues to tie the PR to a specific one?

All Submissions Cores:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?
  • Does your submission pass tests, including CircleCI, Travis CI, and AppVeyor?
  • Does your submission have appropriate code coverage? The cutoff threshold is 95% by Coversall.

This PR addresses the issue of predicting on test data.

I have noticed that some outlier methods do not correctly apply their methods to test data. They simply fix a new OD to the test data instead of evaluating it against the fitted OD on the train data. CD was one such case, and this PR has rectified the issue with minimal changes.

In the future, I will investigate the other OD methods that have this issue to try and align them in this manner too.

@coveralls
Copy link

coveralls commented Feb 1, 2025

Pull Request Test Coverage Report for Build 13085676475

Details

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 95.363%

Totals Coverage Status
Change from base Build 12743748830: 0.002%
Covered Lines: 10366
Relevant Lines: 10870

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants