Aligned CD train-test functionality #624
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions Basics:
All Submissions Cores:
This PR addresses the issue of predicting on test data.
I have noticed that some outlier methods do not correctly apply their methods to test data. They simply fix a new OD to the test data instead of evaluating it against the fitted OD on the train data.
CD
was one such case, and this PR has rectified the issue with minimal changes.In the future, I will investigate the other OD methods that have this issue to try and align them in this manner too.