move tests to root directory #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests are included in the build, which means they are typically shipped when distributed: https://packages.ubuntu.com/focal/all/python3-blockdiag/filelist One solution would be for the distributors to remove those files from the build. But another (better) solution would be to not include them in the first place. This can be achieved by moving the tests outside of the application code. Doing that is actually the recommended layout from pytest: https://docs.pytest.org/en/stable/explanation/goodpractices.html#tests-outside-application-code This patch just move files, modify some links, and add a conftest.py file, needed to modify sys.path
arenevier
added a commit
to arenevier/seqdiag
that referenced
this pull request
Jul 9, 2024
Those methods are import from blockdiag. But now that blockdiag does not ships its test files, the tests were failing. yuzutech/blockdiag#15
arenevier
added a commit
to arenevier/actdiag
that referenced
this pull request
Jul 21, 2024
Those methods are import from blockdiag. But now that blockdiag does not ships its test files, the tests were failing. yuzutech/blockdiag#15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are included in the build, which means they are typically shipped when distributed: https://packages.ubuntu.com/focal/all/python3-blockdiag/filelist
One solution would be for the distributors to remove those files from the build. But another (better) solution would be to not include them in the first place.
This can be achieved by moving the tests outside of the application code. Doing that is actually the recommended layout from pytest:
https://docs.pytest.org/en/stable/explanation/goodpractices.html#tests-outside-application-code
This patch just move files, modify some links, and add a conftest.py file, needed to modify sys.path