Fix: App audio doesn't get recorded when mic is disabled #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@closetothe Thanks! |
|
@closetothe hey, how I can use your fork? I have exactly the same problem: I can not record app audio whlist disabling mic (my goal is to use Playback category for quality audio) |
| - targetSdkVersion = 31 | ||
| - use [HBRecorder](https://github.com/HBiSoft/HBRecorder) | ||
|
|
||
| - Support Expo by using [expo-record-screen-config-plugin](https://github.com/closetothe/expo-record-screen-config-plugin) |
Contributor
There was a problem hiding this comment.
why not merge the plugin here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two sources of audio: the microphone and the app. The original implementation deliberately mutes the app audio when microphoneEnabled = false. Users should be able to record the app screen and audio without having to enable the microphone (which squashes the app audio quality since the audio mode gets set to PlaybackRecord).
Also I added the installation instructions for Expo users (it uses an expo config plugin)