Skip to content

Commit

Permalink
fix: build macosx platform tag
Browse files Browse the repository at this point in the history
  • Loading branch information
yugasun committed Jun 27, 2023
1 parent 3dd54f3 commit e84e8f5
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 137 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ jobs:
- name: Preqrequisites
run: |
brew install cmake libusb pkg-config openssl
brew install --cask powershell
# run build command
- name: Build librealsense2
Expand All @@ -54,7 +53,7 @@ jobs:
with:
repo_token: ${{ secrets.GITHUB_TOKEN }}
file: dist/*
tag: "mac-${{ github.event.inputs.tag }}${{ github.event.inputs.label }}"
tag: "${{ github.event.inputs.tag }}${{ github.event.inputs.label }}"
release_name: "pyrealsense2-mac ${{ github.event.inputs.tag }}${{ github.event.inputs.label }}"
body: "Prebuilt pyrealsense2-mac wheel packages for MacOS for librealsense2 version ${{ github.event.inputs.tag }}."
overwrite: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
tag:
description: 'Version Tag'
required: false
default: 'mac-v2.54.1'
default: 'v2.54.1'


jobs:
Expand Down
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ Install [homebrew](https://brew.sh/) and the following packages:
```bash
sudo xcode-select --install
brew install cmake pkg-config openssl
brew install --cask powershell
brew install [email protected]
```

Expand All @@ -72,10 +71,10 @@ Build for a specific macos version, default is `13`:
bash build.sh -m 11
```

It is possible to set the [tag version](https://github.com/IntelRealSense/librealsense/tags) to build older releases:
It is possible to set the [tag version](https://github.com/IntelRealSense/librealsense/tags) to build older releases, default is `v2.54.1`:

```bash
bash build.sh -t v2.49.0
bash build.sh -t v2.51.1
```

The prebuild wheel files are copied into the `./dist` directory. By default, the dylib is added to the wheel file with the delocate toolkit. It is possible to disable this behaviour for just the python build:
Expand Down
1 change: 0 additions & 1 deletion README.zh-CN.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ sudo realsense-viewer
```bash
sudo xcode-select --install
brew install cmake pkg-config openssl
brew install --cask powershell
brew install [email protected]
```

Expand Down
129 changes: 0 additions & 129 deletions build.ps1

This file was deleted.

2 changes: 1 addition & 1 deletion build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ replace_strings_in_file "name=package_name" "name=\"pyrealsense2-mac\"" setup.py
replace_strings_in_file "https://github.com/IntelRealSense/librealsense" "https://github.com/yugasun/pyrealsense2-mac" setup.py

pip install wheel
python setup.py bdist_wheel --plat-name=macosx_"$macos"_universal2
python setup.py bdist_wheel --plat-name=macosx_"$macos"_0_universal2

# delocate wheel
if [ "$disableDelocate" = false ]; then
Expand Down

0 comments on commit e84e8f5

Please sign in to comment.