-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc][2.25.1] Add flags for Advisory locks #25659
base: master
Are you sure you want to change the base?
Conversation
Add gflags for Advisory locks
✅ Deploy Preview for infallible-bardeen-164bc9 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Co-authored-by: Sudhanshu Prajapati <[email protected]>
docs/content/preview/explore/ysql-language-features/pg-extensions/extension-pgpartman.md
Show resolved
Hide resolved
@@ -1240,25 +1239,6 @@ EXECUTE FUNCTION check_and_modify_val(); | |||
|
|||
--- | |||
|
|||
### Advisory locks is not yet implemented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has Voyager been updated to know that advisory locks are supported? And it is only so in 2.25.1, what if they migrate to a diffferent version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ddhodge , Voyager changes are tracked by https://yugabyte.atlassian.net/browse/DB-13780. This update to the documentation is independant. Do you want the document changes to be done only after the Voyager changes land on master, so as to be consistent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Voyager uses the link to this section in assessment reports and we have a different workflow to mark a feature as fixed in certain versions, we have to do this separately once Voyager also supports the new YB version where Advisory lock is implemented. We generally don't remove the section in this docs, we just mention the YB version where the feature is fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this back in so Voyager team can resolve from their end
Add gflags for Advisory locks
DOC-638