Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc][2.25.1] Add flags for Advisory locks #25659

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

rthallamko3
Copy link
Contributor

@rthallamko3 rthallamko3 commented Jan 16, 2025

Add gflags for Advisory locks
DOC-638

Add gflags for Advisory locks
Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for infallible-bardeen-164bc9 ready!

Name Link
🔨 Latest commit f434e88
🔍 Latest deploy log https://app.netlify.com/sites/infallible-bardeen-164bc9/deploys/67a647e6e6df0900083dcb7b
😎 Deploy Preview https://deploy-preview-25659--infallible-bardeen-164bc9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rthallamko3 rthallamko3 changed the title Add gflags for Advisory locks Add gflags for Advisory locks for 2.25.1.0 Jan 16, 2025
@ddhodge ddhodge added the area/documentation Documentation needed label Jan 22, 2025
@ddhodge ddhodge removed the request for review from aishwarya24 January 22, 2025 18:45
Copy link
Contributor

@sudhanshu456 sudhanshu456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ddhodge ddhodge changed the title Add gflags for Advisory locks for 2.25.1.0 [doc][2.25.1] Add flags for Advisory locks Jan 26, 2025
@@ -1240,25 +1239,6 @@ EXECUTE FUNCTION check_and_modify_val();

---

### Advisory locks is not yet implemented
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has Voyager been updated to know that advisory locks are supported? And it is only so in 2.25.1, what if they migrate to a diffferent version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddhodge , Voyager changes are tracked by https://yugabyte.atlassian.net/browse/DB-13780. This update to the documentation is independant. Do you want the document changes to be done only after the Voyager changes land on master, so as to be consistent?

Copy link
Contributor

@priyanshi-yb priyanshi-yb Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voyager uses the link to this section in assessment reports and we have a different workflow to mark a feature as fixed in certain versions, we have to do this separately once Voyager also supports the new YB version where Advisory lock is implemented. We generally don't remove the section in this docs, we just mention the YB version where the feature is fixed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this back in so Voyager team can resolve from their end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation needed
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

4 participants