Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc][2024.2.2] auto analyze service #25188

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

yifanguan
Copy link
Contributor

@yifanguan yifanguan commented Dec 5, 2024

This pull request adds one dedicated doc page for auto analyze service feature.
Some links in this pull request depends on pull request: #25097
DOC-527
DOC-600

@yifanguan yifanguan self-assigned this Dec 5, 2024
Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for infallible-bardeen-164bc9 ready!

Name Link
🔨 Latest commit 40923a5
🔍 Latest deploy log https://app.netlify.com/sites/infallible-bardeen-164bc9/deploys/67a6efc8ae77390008f9a93a
😎 Deploy Preview https://deploy-preview-25188--infallible-bardeen-164bc9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ddhodge ddhodge added the area/documentation Documentation needed label Dec 16, 2024
@ddhodge ddhodge requested a review from premkumr December 30, 2024 17:55
@ddhodge ddhodge removed the request for review from aishwarya24 January 8, 2025 16:59
Copy link
Contributor

@premkumr premkumr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ddhodge ddhodge changed the title Add dedicated page for auto analyze service [doc][2024.2.2] auto analyze service Jan 13, 2025
@@ -42,7 +42,7 @@ Increasing either of these flags reduces the frequency of statistics updates.
If the total number of mutations for a table is greater than its analyze threshold, then the service runs ANALYZE on the table. The analyze threshold of a table is calculated as follows:

```sh
analyze_threshold = ysql_auto_analyze_threshold + ysql_auto_analyze_scale_factor * <table_size>
analyze_threshold = ysql_auto_analyze_threshold + (ysql_auto_analyze_scale_factor * <table_size>)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added parenthesis is unnecessary IMO.

@yifanguan
Copy link
Contributor Author

Thanks for your edits @ddhodge. The overall contents look good to me. We need to update the page later as we gradually develop Auto Analyze service.

@ddhodge ddhodge requested a review from markpyb February 8, 2025 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation needed
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

3 participants