Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOUDGA-26189] Use new API's get instance-types, cloud-regions & node-configs #294

Merged
merged 1 commit into from
Mar 20, 2025
Merged

[CLOUDGA-26189] Use new API's get instance-types, cloud-regions & node-configs #294

merged 1 commit into from
Mar 20, 2025

Conversation

bhupendray-yb
Copy link
Contributor

@bhupendray-yb bhupendray-yb commented Feb 18, 2025 •
edited
Loading

  • [CLOUDGA-26189] Use new API's for get instance-types, cloud-regions & node-configs.

Tested via running the below two commands and verifying the API call(via MITM proxy):

$ ./ybm region list --cloud-provider AWS

$ ./ybm region instance list --cloud-provider AWS --region ap-south-1

image

@bhupendray-yb bhupendray-yb requested a review from a team as a code owner February 18, 2025 06:21
posriniv
posriniv approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@posriniv posriniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@bhupendray-yb
Copy link
Contributor Author

ps: I'll merge this once the API changes are in prod.

@bhupendray-yb bhupendray-yb merged commit dbc9662 into main Mar 20, 2025
1 check passed
@bhupendray-yb bhupendray-yb deleted the CLOUDGA-26189 branch March 20, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posriniv posriniv posriniv approved these changes

@bansal01yash bansal01yash bansal01yash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhupendray-yb @posriniv @bansal01yash