Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulk PITR config creation #285

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Bulk PITR config creation #285

merged 1 commit into from
Dec 20, 2024

Conversation

harshitha-yb
Copy link
Contributor

Change the create pitr-config command to work with updated API that takes in multiple config creation requests. Take the params as a string array and do required param validations for each config.

Test plan:

  1. Tested manually-
Screenshot 2024-12-20 at 10 29 32 AM Screenshot 2024-12-20 at 11 26 08 AM Screenshot 2024-12-20 at 11 29 02 AM
  1. UTs

@harshitha-yb harshitha-yb requested a review from a team as a code owner December 20, 2024 06:21
jagdish-yb
jagdish-yb approved these changes Dec 20, 2024
View reviewed changes
Copy link

@jagdish-yb jagdish-yb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated CLI usage lgtm

@harshitha-yb harshitha-yb merged commit 1e34035 into main Dec 20, 2024
1 check passed
@harshitha-yb harshitha-yb deleted the CLOUDGA-24437 branch December 20, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagdish-yb jagdish-yb jagdish-yb approved these changes

@arishta-yb arishta-yb arishta-yb approved these changes

@posriniv posriniv Awaiting requested review from posriniv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshitha-yb @arishta-yb @jagdish-yb