Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOUDGA-24871] Remove feature flag from DB Query Logging #279

Merged
merged 2 commits into from
Dec 5, 2024
Merged

[CLOUDGA-24871] Remove feature flag from DB Query Logging #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fca1b43
[CLOUDGA-24871] Remove feature flag from DB Query Logging
bhupendray-yb Dec 2, 2024
e49bd9b
[CLOUDGA-24871] remove feature flag env var in tests
bhupendray-yb Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/cluster/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ var ClusterCmd = &cobra.Command{
func init() {
ClusterCmd.AddCommand(cert.CertCmd)

util.AddCommandIfFeatureFlag(ClusterCmd, log_exporter.DbQueryLoggingCmd, util.DB_QUERY_LOGS)
ClusterCmd.AddCommand(log_exporter.DbQueryLoggingCmd)
log_exporter.DbQueryLoggingCmd.PersistentFlags().StringVarP(&log_exporter.ClusterName, "cluster-name", "c", "", "[REQUIRED] The name of the cluster.")
log_exporter.DbQueryLoggingCmd.MarkPersistentFlagRequired("cluster-name")

Expand Down
1 change: 0 additions & 1 deletion cmd/db_query_logs_exporter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ var _ = Describe("DB Query Logging", func() {
Expect(err).ToNot(HaveOccurred())
os.Setenv("YBM_HOST", fmt.Sprintf("http://%s", server.Addr()))
os.Setenv("YBM_APIKEY", "test-token")
os.Setenv("YBM_FF_DB_QUERY_LOGGING", "true")
statusCode = 200
err = loadJson("./test/fixtures/list-clusters.json", &responseListClusters)
Expect(err).ToNot(HaveOccurred())
Expand Down
1 change: 0 additions & 1 deletion cmd/util/feature_flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ const (
CONNECTION_POOLING FeatureFlag = "CONNECTION_POOLING"
GOOGLECLOUD_INTEGRATION FeatureFlag = "GOOGLECLOUD_INTEGRATION"
DR FeatureFlag = "DR"
DB_QUERY_LOGS FeatureFlag = "DB_QUERY_LOGGING"
)

func (f FeatureFlag) String() string {
Expand Down