Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added deprecation messages for metrics export commands #277

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Added deprecation messages for metrics export commands #277

merged 1 commit into from
Dec 5, 2024

Conversation

bansal01yash
Copy link
Contributor

@bansal01yash bansal01yash commented Dec 2, 2024 •
edited
Loading

Added deprecation messages for metrics export commands

./ybm metrics-exporter list
Command "list" is deprecated, use "integration list" instead.
This command was deprecated 2024-11-30 and will be supported until 2025-2-28.
Name              Type
yash-dpn          DATADOG
prometheus-full   VICTORIAMETRICS

@bansal01yash bansal01yash requested a review from a team as a code owner December 2, 2024 09:04
@bansal01yash bansal01yash force-pushed the Add-deprecation-messages branch from 1f11b00 to 709fa19 Compare December 2, 2024 09:07
posriniv
posriniv approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@posriniv posriniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

ddhodge
ddhodge reviewed Dec 3, 2024
View reviewed changes
cmd/metrics_exporter/metrics_exporter.go Outdated Show resolved Hide resolved
cmd/metrics_exporter/metrics_exporter.go Outdated Show resolved Hide resolved
cmd/metrics_exporter/metrics_exporter.go Outdated Show resolved Hide resolved
cmd/metrics_exporter/metrics_exporter.go Outdated Show resolved Hide resolved
cmd/metrics_exporter/metrics_exporter.go Outdated Show resolved Hide resolved
cmd/metrics_exporter/metrics_exporter.go Outdated Show resolved Hide resolved
cmd/metrics_exporter/metrics_exporter.go Outdated Show resolved Hide resolved
cmd/metrics_exporter/metrics_exporter.go Outdated Show resolved Hide resolved
cmd/metrics_exporter/metrics_exporter.go Outdated Show resolved Hide resolved
cmd/metrics_exporter/metrics_exporter.go Outdated Show resolved Hide resolved
@bansal01yash bansal01yash force-pushed the Add-deprecation-messages branch 3 times, most recently from e4c0fec to 36846d8 Compare December 4, 2024 10:57
@bansal01yash bansal01yash force-pushed the Add-deprecation-messages branch from 36846d8 to d8c6cd8 Compare December 4, 2024 10:58
ddhodge
ddhodge approved these changes Dec 4, 2024
View reviewed changes
Copy link

@ddhodge ddhodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bansal01yash bansal01yash merged commit bb818e3 into main Dec 5, 2024
1 check passed
@bansal01yash bansal01yash deleted the Add-deprecation-messages branch December 5, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddhodge ddhodge ddhodge approved these changes

@posriniv posriniv posriniv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bansal01yash @posriniv @ddhodge