Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOUDGA-24744] Add support for integration type VICTORIAMETRICS #275

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

bhupendray-yb
Copy link
Contributor

@bhupendray-yb bhupendray-yb commented Nov 21, 2024

Create Integration

~/code/ybm-cli on CLOUDGA-24744 *5 ?1                                                                                                                          at 14:33:16
> mb && ./ybm integration create --config-name vm-test --type VICTORIAMETRICS  --victoriametrics-spec endpoint=http://victoriametrics.yourcompany.com
go build -ldflags="-X 'main.version=v0.1.0'" -o ybm
you are using insecure api endpoint http://127.0.0.1:5678
The Integration vm-test has been created
ID                                     Name      Type              Endpoint
8c02a496-5032-4a29-84fd-3838b901af09   vm-test   VICTORIAMETRICS   http://victoriametrics.yourcompany.com

Delete Integration:

~/code/ybm-cli on CLOUDGA-24744 *5 ?1                                                                                                                          at 14:33:20
> mb && ./ybm integration delete --config-name vm-test
go build -ldflags="-X 'main.version=v0.1.0'" -o ybm
? Are you sure you want to delete config: vm-test Yes
you are using insecure api endpoint http://127.0.0.1:5678
The Integration vm-test has been deleted

Copy link
Contributor

@bansal01yash bansal01yash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need confirmation on whether or not we need the Feature Flag

Copy link
Contributor

@Siddarth-Baldwa Siddarth-Baldwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bansal01yash bansal01yash merged commit cc43cef into main Nov 27, 2024
1 check passed
@bansal01yash bansal01yash deleted the CLOUDGA-24744 branch November 27, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants