[CLOUDGA-19629] Add support for telemetry provider #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinji62
reviewed
Mar 15, 2024
jagdish-yb
approved these changes
Mar 20, 2024
shinji62
approved these changes
Mar 21, 2024
I'll add a commit to remove the validate method and send a total of 2 commits in this PR, so that we can revert this commit if we want to add validate method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change adds telemetry provider apis.
Almost everything is similar to metric export apis which is based on telemetry CRUD.
I've added IDs in all api outputs and introduced validate command. IDs are used in DB audit apis for specifying telemetry_provider to use.
Test Plan:
Added UTs for the change.
CLI operation logs:
[rkumar@dev-server-rkumar-31 ybm-cli]$ ./ybm integration create --config-name=dd --type=datadog --datadog-spec=site=datadoghq.com,api-key=f4XXXXXXXXXXXXXXXXXXXXXXXXXXXXbf A newer version is available. Please upgrade to the latest version v0.1.18 The telemetry provider 51bf0334-4aef-430d-892c-aa840d00dc26 is being created ID Name Type Site ApiKey 51bf0334-4aef-430d-892c-aa840d00dc26 dd DATADOG [datadoghq.com](http://datadoghq.com/) f4XXXXXXXXXXXXXXXXXXXXXXXXXXXXbf [rkumar@dev-server-rkumar-31 ybm-cli]$ ./ybm integration update --config-name=dd --new-config-name=ddog --type=datadog --datadogfspec=site=datadoghq.com,api-key=f4XXXXXXXXXXXXXXXXXXXXXXXXXXXXbf A newer version is available. Please upgrade to the latest version v0.1.18 The telemetryProvider 51bf0334-4aef-430d-892c-aa840d00dc26 is being updated ID Name Type Site ApiKey 51bf0334-4aef-430d-892c-aa840d00dc26 ddog DATADOG [datadoghq.com](http://datadoghq.com/) f4XXXXXXXXXXXXXXXXXXXXXXXXXXXXbf [rkumar@dev-server-rkumar-31 ybm-cli]$ ./ybm integration list A newer version is available. Please upgrade to the latest version v0.1.18 ID Name Type 51bf0334-4aef-430d-892c-aa840d00dc26 ddog DATADOG 2c21e4fd-a39c-4958-bfe6-80e727dc2820 ss DATADOG [rkumar@dev-server-rkumar-31 ybm-cli]$ ./ybm integration delete --config-name=ddog A newer version is available. Please upgrade to the latest version v0.1.18 ? Are you sure you want to delete config: ddog Yes Deleting Telemetry Provider ddog [rkumar@dev-server-rkumar-31 ybm-cli]$ ./ybm integration validate --config-name=dd --type=datadog --datadog-spec=site=datadoghq.com,api-key=f4XXXXXXXXXXXXXXXXXXXXXXXXXXXXbf A newer version is available. Please upgrade to the latest version v0.1.18 Telemetry provider is valid