Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOUDGA-18024] Handle the case when last rotated is null #204

Merged
merged 1 commit into from
Dec 5, 2023
Merged

[CLOUDGA-18024] Handle the case when last rotated is null #204

merged 1 commit into from
Dec 5, 2023

Conversation

arishta-yb
Copy link
Contributor

Summary:
This PR handles the case when last rotated param for CMK config is null.


[arjain@dev-server-arjain ybm-cli]$ ./ybm cluster encryption list --cluster-name npavithra-azure-target
A newer version is available. Please upgrade to the latest version v0.1.17
Provider   Key Alias                              Last Rotated   Security Principals                      CMK Status
AZURE      99ad65ab-d6bf-4950-b5f2-1806b2fd682f   -              https://test-azure-gj.vault.azure.net/   ACTIVE

@arishta-yb arishta-yb requested review from cdavid and shinji62 December 5, 2023 05:19
@arishta-yb arishta-yb requested a review from a team as a code owner December 5, 2023 05:19
@shinji62
Copy link
Collaborator

shinji62 commented Dec 5, 2023

Add teest please.

@arishta-yb arishta-yb force-pushed the CLOUDGA-18024-fix-last-rotated-error branch from 9fb2514 to 56c5edc Compare December 5, 2023 06:05
@arishta-yb
Copy link
Contributor Author

@shinji62
Added UT, please TAL.

@shinji62
Copy link
Collaborator

shinji62 commented Dec 5, 2023

@shinji62 Added UT, please TAL.
Don 't change the test just add another one.
After that we should be good,

@arishta-yb arishta-yb force-pushed the CLOUDGA-18024-fix-last-rotated-error branch from 56c5edc to 997958f Compare December 5, 2023 14:15
@arishta-yb
Copy link
Contributor Author

@shinji62 Added new unit test, please TAL

@arishta-yb arishta-yb merged commit b9b78fc into main Dec 5, 2023
2 checks passed
@arishta-yb arishta-yb deleted the CLOUDGA-18024-fix-last-rotated-error branch December 5, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdavid cdavid cdavid approved these changes

@shinji62 shinji62 Awaiting requested review from shinji62

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arishta-yb @shinji62 @cdavid