Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some pending review comments from previous PRs #2260

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

priyanshi-yb
Copy link
Contributor

@priyanshi-yb priyanshi-yb commented Jan 28, 2025

Describe the changes in this pull request

  1. Changed the deep-copy library to github.com/jinzhu/copier as it looks more popular and maintained (last updated 6months ago). (comment from Fix: Do not redact password for conn pool connection uri while connecting to DB  #2203 )
  2. Change the Stringbuilder.append to String.format() in java debezium exporter for MAP type conversion. (comment from Fix: MAP value converter for data via debezium #2156)

Describe if there are any user-facing changes

No

How was this pull request tested?

existing tests are enough
https://jenkins.dev.yugabyte.com/job/users/job/yb-voyager-testing/job/yb-voyager-testing-pipeline/4603/

Does your PR have changes that can cause upgrade issues?

Component Breaking changes?
MetaDB No
Name registry json No
Data File Descriptor Json No
Export Snapshot Status Json No
Import Data State No
Export Status Json No
Data .sql files of tables No
Export and import data queue No
Schema Dump No
AssessmentDB No
Sizing DB No
Migration Assessment Report Json No
Callhome Json No
YugabyteD Tables No
TargetDB Metadata Tables No

@priyanshi-yb priyanshi-yb changed the title Some Pending review comments from previous PRs Some pending review comments from previous PRs Jan 28, 2025
@priyanshi-yb priyanshi-yb marked this pull request as ready for review January 28, 2025 09:01
@priyanshi-yb priyanshi-yb merged commit 18d3d28 into main Jan 28, 2025
68 checks passed
@priyanshi-yb priyanshi-yb deleted the priyanshi/pending-review-comments branch January 28, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants