Send error messages to callhome #2160

makalaaneesh · 2025-01-08T07:57:25Z

Describe the changes in this pull request

Send error messages in each phase to callhome as part of phase payload.

callhome=# select * from diagnostics  where migration_uuid='70c74cb8-0c8a-42cc-86d0-10d5e39a4cb8';
-[ RECORD 1 ]------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
migration_uuid     | 70c74cb8-0c8a-42cc-86d0-10d5e39a4cb8
phase_start_time   | 2025-01-08 08:04:45.790466+00
collected_at       | 2025-01-08 08:04:45.904148+00
source_db_details  | {"host": "", "db_type": "postgresql", "db_version": "", "total_db_size_bytes": 0}
target_db_details  |
yb_voyager_version | main
migration_phase    | export-schema
phase_payload      | {"error": "run query \"SELECT setting from pg_settings where name = server_version\" on source", "use_orafce": true, "start_clean": true, "comments_on_objects": false, "applied_recommendations": false}
migration_type     |
time_taken_sec     | 1
status             | ERROR
host_ip            | 100.76.18.48

Describe if there are any user-facing changes

How was this pull request tested?

Manual testing against local callhome server.

Does your PR have changes that can cause upgrade issues?

Component	Breaking changes?
MetaDB	Yes/No
Name registry json	Yes/No
Data File Descriptor Json	Yes/No
Export Snapshot Status Json	Yes/No
Import Data State	Yes/No
Export Status Json	Yes/No
Data .sql files of tables	Yes/No
Export and import data queue	Yes/No
Schema Dump	Yes/No
AssessmentDB	Yes/No
Sizing DB	Yes/No
Migration Assessment Report Json	Yes/No
Callhome Json	Yes/No
YugabyteD Tables	Yes/No
TargetDB Metadata Tables	Yes/No

priyanshi-yb · 2025-01-09T06:54:54Z

yb-voyager/cmd/assessMigrationBulkCommand.go

@@ -57,14 +57,14 @@ var assessMigrationBulkCmd = &cobra.Command{
 	Run: func(cmd *cobra.Command, args []string) {
 		err := assessMigrationBulk()
 		if err != nil {
-			packAndSendAssessMigrationBulkPayload(ERROR)
+			// packAndSendAssessMigrationBulkPayload(ERROR)


remove comment

priyanshi-yb · 2025-01-09T08:15:49Z

yb-voyager/cmd/exportData.go

@@ -1046,7 +1047,7 @@ func extractTableListFromString(fullTableList []sqlname.NameTuple, flagTableList
 		result := lo.Filter(fullTableList, func(tableName sqlname.NameTuple, _ int) bool {
 			ok, err := tableName.MatchesPattern(pattern)
 			if err != nil {
-				utils.ErrExit("Invalid table name pattern %q: %s", err)
+				utils.ErrExit("Invalid table name pattern %q: %s", pattern, err)


just confirm if we have fixed it in modify error strings PR.

utils.ErrExit("Invalid table name pattern: %q: %s", pattern, err)

priyanshi-yb · 2025-01-09T08:16:16Z

yb-voyager/cmd/exportDataStatus.go

@@ -262,7 +262,7 @@ func startExportPB(progressContainer *mpb.Progress, mapKey string, quitChan chan
 				time.Sleep(100 * time.Millisecond)
 				break
 			} else if err != nil { //error other than EOF
-				utils.ErrExit("Error while reading file %s: %v", tableDataFile, err)
+				utils.ErrExit("Error while reading file %s: %v", tableDataFile.Name(), err)


same for this as above
utils.ErrExit("Error while reading file: %s: %v", tableDataFile.Name(), err)

priyanshi-yb · 2025-01-09T08:17:28Z

yb-voyager/src/srcdb/postgres.go

@@ -785,7 +785,7 @@ WHERE parent.relname='%s' AND nmsp_parent.nspname = '%s' `, tname, sname)
 	rows, err := pg.db.Query(query)
 	if err != nil {
 		log.Errorf("failed to list partitions of table %s: query = [ %s ], error = %s", tableName, query, err)
-		utils.ErrExit("failed to find the partitions for table %s:", tableName, err)
+		utils.ErrExit("failed to find the partitions for table %s: %v", tableName, err)


utils.ErrExit("failed to find the partitions for table: %s: %v", tableName, err)

priyanshi-yb · 2025-01-09T08:17:47Z

yb-voyager/src/srcdb/yugabytedb.go

@@ -756,7 +756,7 @@ WHERE parent.relname='%s' AND nmsp_parent.nspname = '%s' `, tname, sname)
 	rows, err := yb.db.Query(query)
 	if err != nil {
 		log.Errorf("failed to list partitions of table %s: query = [ %s ], error = %s", tableName, query, err)
-		utils.ErrExit("failed to find the partitions for table %s:", tableName, err)
+		utils.ErrExit("failed to find the partitions for table %s: %v", tableName, err)


utils.ErrExit("failed to find the partitions for table: %s: %v", tableName, err)

priyanshi-yb · 2025-01-09T08:19:33Z

yb-voyager/cmd/importSchema.go

-		if len(errorsList) > 0 && status != EXIT {
-			payload.Status = COMPLETE_WITH_ERRORS
-		}
+	// if status == ERROR {


remove comments

priyanshi-yb · 2025-01-09T08:21:17Z

yb-voyager/cmd/export.go

@@ -299,7 +299,7 @@ func validateSSLMode() {
 	if source.DBType == ORACLE || slices.Contains(validSSLModes[source.DBType], source.SSLMode) {
 		return
 	} else {
-		utils.ErrExit("Error: Invalid sslmode: %q. Valid SSL modes are %v", validSSLModes[source.DBType])
+		utils.ErrExit("Error: Invalid sslmode: %q. Valid SSL modes are %v", source.SSLMode, validSSLModes[source.DBType])


utils.ErrExit("Invalid sslmode: %q. Valid SSL modes are %v", source.SSLMode, validSSLModes[source.DBType])

priyanshi-yb

LGTM!

makalaaneesh added 5 commits January 8, 2025 11:09

wip

5216000

pass errormsg

2d7624f

adding error msg to payload

5ebc0f5

build errors

3f048c2

more build errors

76959dc

makalaaneesh requested a review from priyanshi-yb January 8, 2025 14:42

makalaaneesh marked this pull request as ready for review January 8, 2025 14:42

comment

9d32827

priyanshi-yb reviewed Jan 9, 2025

View reviewed changes

makalaaneesh added 2 commits January 9, 2025 14:02

remove comments

a562ddb

fix test

80eb105

priyanshi-yb approved these changes Jan 9, 2025

View reviewed changes

makalaaneesh merged commit b9e614d into main Jan 9, 2025
67 checks passed

makalaaneesh deleted the aneesh/callhome-error branch January 9, 2025 09:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Send error messages to callhome #2160

Send error messages to callhome #2160

makalaaneesh commented Jan 8, 2025 •

edited

Loading

priyanshi-yb Jan 9, 2025

priyanshi-yb Jan 9, 2025

priyanshi-yb Jan 9, 2025

priyanshi-yb Jan 9, 2025

priyanshi-yb Jan 9, 2025

priyanshi-yb Jan 9, 2025

priyanshi-yb Jan 9, 2025

priyanshi-yb left a comment

Send error messages to callhome #2160

Send error messages to callhome #2160

Conversation

makalaaneesh commented Jan 8, 2025 • edited Loading

Describe the changes in this pull request

Describe if there are any user-facing changes

How was this pull request tested?

Does your PR have changes that can cause upgrade issues?

priyanshi-yb Jan 9, 2025

Choose a reason for hiding this comment

priyanshi-yb Jan 9, 2025

Choose a reason for hiding this comment

priyanshi-yb Jan 9, 2025

Choose a reason for hiding this comment

priyanshi-yb Jan 9, 2025

Choose a reason for hiding this comment

priyanshi-yb Jan 9, 2025

Choose a reason for hiding this comment

priyanshi-yb Jan 9, 2025

Choose a reason for hiding this comment

priyanshi-yb Jan 9, 2025

Choose a reason for hiding this comment

priyanshi-yb left a comment

Choose a reason for hiding this comment

makalaaneesh commented Jan 8, 2025 •

edited

Loading