[CLOUDGA-17429] Add Azure CMK support to Terraform #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinji62
reviewed
Nov 1, 2023
shinji62
reviewed
Nov 1, 2023
|
As you have update the managed import you need to regenerate the mock api, https://github.com/uber-go/mock For example for the AccountApi |
arishta-yb
force-pushed
the
CLOUDGA-17249-add-azure-support
branch
from
8b1b7f6 to
c7e52e2
Compare
cdavid
reviewed
Nov 2, 2023
arishta-yb
force-pushed
the
CLOUDGA-17249-add-azure-support
branch
from
c7e52e2 to
7b2e804
Compare
Addressed all the comments, please TAL. |
Updated Mock Update Docs addressed comments
arishta-yb
force-pushed
the
CLOUDGA-17249-add-azure-support
branch
from
7b2e804 to
c4848b1
Compare
arishta-yb
changed the title
cdavid
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds support for Azure CMK:
Additionally, also fixed a backupDescription related issue in this PR.
cannot use &backupDescription (value of type *string) as openapi.NullableString value in assignment