Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to log configuration docs #148

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Changes to log configuration docs #148

merged 1 commit into from
Jan 24, 2025
+26 −22

Conversation

bansal01yash
Copy link
Contributor

  1. Added reference to log resources in integration resource
  2. Improved doc for log resources
  3. Fixed error in cluster doc

@bansal01yash bansal01yash requested a review from a team as a code owner January 15, 2025 14:53
@bansal01yash bansal01yash force-pushed the log-configuration-docs branch from b7e71e1 to 32dd9fa Compare January 15, 2025 14:56
ddhodge
ddhodge reviewed Jan 15, 2025
View reviewed changes
docs/resources/associate_metrics_exporter_cluster.md Outdated Show resolved Hide resolved
docs/resources/db_audit_logging.md Outdated Show resolved Hide resolved
docs/resources/db_audit_logging.md Outdated Show resolved Hide resolved
docs/resources/db_query_logging.md Outdated Show resolved Hide resolved
docs/resources/db_query_logging.md Outdated Show resolved Hide resolved
managed/resource_db_audit_logging.go Outdated Show resolved Hide resolved
managed/resource_db_audit_logging.go Outdated Show resolved Hide resolved
managed/resource_db_query_logging.go Outdated Show resolved Hide resolved
managed/resource_db_query_logging.go Outdated Show resolved Hide resolved
@bansal01yash bansal01yash force-pushed the log-configuration-docs branch from 32dd9fa to a42a16b Compare January 16, 2025 09:04
@bansal01yash bansal01yash requested a review from ddhodge January 16, 2025 09:05
ddhodge
ddhodge approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@ddhodge ddhodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with small fix

docs/resources/associate_metrics_exporter_cluster.md Outdated Show resolved Hide resolved
docs/resources/associate_metrics_exporter_cluster.md Outdated Show resolved Hide resolved
@bansal01yash bansal01yash force-pushed the log-configuration-docs branch from a42a16b to c40a3da Compare January 16, 2025 18:29
@bansal01yash bansal01yash merged commit 7cb7962 into main Jan 24, 2025
2 checks passed
@bansal01yash bansal01yash deleted the log-configuration-docs branch January 24, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siddarth-Baldwa Siddarth-Baldwa Siddarth-Baldwa approved these changes

@ddhodge ddhodge ddhodge approved these changes

@atharva-yb atharva-yb atharva-yb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bansal01yash @Siddarth-Baldwa @ddhodge @atharva-yb