Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOUDGA-25006] Deprecate root node info #143

Merged
merged 1 commit into from
Dec 10, 2024
Merged

[CLOUDGA-25006] Deprecate root node info #143

merged 1 commit into from
Dec 10, 2024

Conversation

daniel-yb
Copy link
Contributor

@daniel-yb daniel-yb commented Dec 4, 2024

Deprecate root node info. Mark the root one optional.

Using the deprecated fields will now result in:

╷
│ Warning: Attribute Deprecated
│ 
│   with ybm_cluster.single_region,
│   on cluster-single-region.tf line 50, in resource "ybm_cluster" "single_region":
│   50:   node_config = {
│   51:     num_cores    = 2
│   52:     disk_size_gb = 10
│   53:   }
│ 
│ Remove this attribute's configuration as it's no longer in use and the attribute will be removed in the next major version of the provider. Please use cluster_region_info to specify node
│ config instead.
│ 
│ (and one more similar warning elsewhere)
╵

@daniel-yb daniel-yb requested a review from a team as a code owner December 4, 2024 22:08
Copy link
Collaborator

@posriniv posriniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@daniel-yb daniel-yb merged commit 4086375 into main Dec 10, 2024
2 checks passed
@daniel-yb daniel-yb deleted the CLOUDGA-25006 branch December 10, 2024 00:16
@daniel-yb daniel-yb restored the CLOUDGA-25006 branch December 10, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants