Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc changes for Integrations and Metrics Export #136

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Doc changes for Integrations and Metrics Export #136

merged 4 commits into from
Nov 27, 2024

Conversation

bansal01yash
Copy link
Contributor

Doc changes for the following

  1. Set sunset date for deprecated metrics resource
  2. Integrations and Metrics Export doc improvements -> Tried to keep it similar to public docs as well associate metrics export description changed to be similar to other log exports.
  3. Prometheus and VictoriaMetrics Integrations docs added

@bansal01yash bansal01yash requested a review from a team as a code owner November 27, 2024 09:09
atharva-yb
atharva-yb approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@atharva-yb atharva-yb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

examples/resources/ybm_integration/prometheus-integration.tf Outdated Show resolved Hide resolved
Siddarth-Baldwa
Siddarth-Baldwa approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@Siddarth-Baldwa Siddarth-Baldwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits. Rest lgtm

docs/resources/integration.md Outdated Show resolved Hide resolved
examples/resources/ybm_integration/vm-integration.tf Outdated Show resolved Hide resolved
posriniv
posriniv approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@posriniv posriniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@bansal01yash bansal01yash merged commit 2c288e9 into main Nov 27, 2024
2 checks passed
@bansal01yash bansal01yash deleted the various-doc-changes branch November 27, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posriniv posriniv posriniv approved these changes

@Siddarth-Baldwa Siddarth-Baldwa Siddarth-Baldwa approved these changes

@atharva-yb atharva-yb atharva-yb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bansal01yash @posriniv @Siddarth-Baldwa @atharva-yb