Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ WIP ]Added Terratest Plan #6

Closed
wants to merge 36 commits into from
Closed

Conversation

vaibhavp
Copy link
Contributor

Added terratest plan for the terraform-gcp-yugabyte module. It's an incremental PR, I will be adding more test cases to it.

@vaibhavp vaibhavp requested a review from ramkumarvs September 26, 2019 10:44
@vaibhavp vaibhavp changed the title Added Terratest Plan [ WIP ]Added Terratest Plan Sep 26, 2019
credentials = "${file(var.credentials)}"
project = var.project_id
}

data "google_compute_image" "YugaByte_DB_Image" {
family = "centos-6"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do this test on a few OS's - such as ad Ubuntu and others. We can not assume the end-user will always use Ubuntu. I think Github action allows you to run the same workflow for a combination of OS - I would suggest exploring that.

@samkulkarni20
Copy link

closing this as we have #12 for GitHub actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants