FIX: readme update for basic CDC setup #324 #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaibhav-yb
reviewed
Oct 24, 2024
There was a problem hiding this comment.
Hi @gouravk3 Can you please update the description to mention why was the change needed from hostname -i to hostname -I | awk '{print $1}'?
It is fine currently, but once the description of the PR will go to the commit description once we merge the PR, that will help anybody in future understand the commit quickly without going to a bunch of hyperlinks.
|
Hi @vaibhav-yb, I have updated the description of the PR, please have a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the readme for running the basic CDC setup, will be the fix for issue #324
The command
hostname -ioutputs the IP address associated with the hostname of the machine, whilehostname -Idisplays all network interfaces IP addresses on the machine.When
advertise_addressis set as machine's hostname, and while deploying the connector configurations, error was returned. This can be fixed by passing one of the networks IP address.