[WIP] Create a JDBC connection only while decoding array types #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaibhav-yb
commented
Jun 12, 2024
| @@ -29,7 +30,7 @@ | |||
| * @author Vaibhav Kushwaha ([email protected]) | |||
| */ | |||
|
|
|||
| public class YugabyteDBDatatypesTest extends YugabyteDBContainerTestBase { | |||
| public class YugabyteDBDatatypesTest extends YugabytedTestBase { | |||
There was a problem hiding this comment.
Todo Vaibhav: Revert this change before final review.
vaibhav-yb
commented
Jun 12, 2024
| @@ -26,16 +31,17 @@ | |||
|
|
|||
| import static org.junit.jupiter.api.Assertions.*; | |||
|
|
|||
| public class YugabyteDBCompleteTypesTest extends YugabyteDBContainerTestBase { | |||
| public class YugabyteDBCompleteTypesTest extends YugabytedTestBase { | |||
There was a problem hiding this comment.
Todo Vaibhav: Revert this change before final review.
vaibhav-yb
commented
Jun 12, 2024
| Arguments.of(false, false), // Older stream | ||
| Arguments.of(true, false)); // NO_EXPORT stream | ||
| Arguments.of(false, false)); // Older stream | ||
| // Arguments.of(true, false)); // NO_EXPORT stream |
There was a problem hiding this comment.
Todo Vaibhav: Revert this change before final review.
vaibhav-yb
force-pushed
the
remove-jdbc-dependency
branch
from
8214345
to
4e492ca
Compare
suranjan
requested changes
Jun 12, 2024
src/main/java/io/debezium/connector/yugabytedb/YugabyteDBChangeEventSourceFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/io/debezium/connector/yugabytedb/YugabyteDBChangeEventSourceFactory.java
Outdated
Show resolved
Hide resolved
| @@ -196,8 +196,7 @@ private Object[] columnValues(List<ReplicationMessage.Column> columns, TableId t | |||
| undeliveredToastableColumns.remove(columnName); | |||
| int position = getPosition(columnName, table, values); | |||
| if (position != -1) { | |||
| Object value = column.getValue(() -> (BaseConnection) connection.connection(), | |||
| connectorConfig.includeUnknownDatatypes()); | |||
There was a problem hiding this comment.
why is this change needed, connection.connection() can return null/connection depending on the context
There was a problem hiding this comment.
The YugabyteDBConnection object doesn't have any context of what type of data it will be used to decode. In case an array type is encountered, then a JDBC connection is created to be used otherwise it would be just the YugabyteDBConnection object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
YugabyteDBConnectoropens a global JDBC connection which is used to decode data types, this connection is created only once per task and is retained for the complete lifetime of the task. However, one task per connection creates a problem when the task count is high and we end up in a state where we have a lot of JDBC connections open.Since the change events the connector receives are already decoded in case of non-array types, a JDBC connection is not really needed to decode them so unless there's an array type in the table the connector is polling, the connection keeps hogging resources.
Solution
This PR aims to change the behaviour and only uses a JDBC connection while decoding array types.