Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alter table ddl as alter table set storage plan is not needed for yb #2

Open
wants to merge 3 commits into
base: main-yb
Choose a base branch
from
Open

Remove alter table ddl as alter table set storage plan is not needed for yb #2

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43708e9
alter table set storage plan is not needed for yb
shaharuk-yb Jan 8, 2025
6f8718f
change hnsw to ybhnsw, default function to l2 for yugabyte
shaharuk-yb Jan 10, 2025
89594c6
add support to provide parameters for before/after index creation
shaharuk-yb Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions vectordb_bench/backend/clients/pgvector/pgvector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,11 +387,11 @@ def _create_table(self, dim: int):
"CREATE TABLE IF NOT EXISTS public.{table_name} (id BIGINT PRIMARY KEY, embedding vector({dim}));"
).format(table_name=sql.Identifier(self.table_name), dim=dim)
)
self.cursor.execute(
sql.SQL(
"ALTER TABLE public.{table_name} ALTER COLUMN embedding SET STORAGE PLAIN;"
).format(table_name=sql.Identifier(self.table_name))
)
# self.cursor.execute(
# sql.SQL(
# "ALTER TABLE public.{table_name} ALTER COLUMN embedding SET STORAGE PLAIN;"
# ).format(table_name=sql.Identifier(self.table_name))
# )
self.conn.commit()
except Exception as e:
log.warning(
Expand Down