Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Table/DownloadManager): fix event listener #970

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/ui/tests/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ node_modules/
/playwright-report/
/playwright/.cache/
.env
/downloads/
25 changes: 16 additions & 9 deletions packages/ui/tests/e2e/pages/table.download-manager.base.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {expect, test} from '@playwright/test';

Check failure on line 1 in packages/ui/tests/e2e/pages/table.download-manager.base.spec.ts

View workflow job for this annotation

GitHub Actions / E2E for 'Local'

[chromium] › e2e/pages/table.download-manager.base.spec.ts:9:5 › Download manager: downloaded file should be equal to ideal

1) [chromium] › e2e/pages/table.download-manager.base.spec.ts:9:5 › Download manager: downloaded file should be equal to ideal Test timeout of 10000ms exceeded.

Check failure on line 1 in packages/ui/tests/e2e/pages/table.download-manager.base.spec.ts

View workflow job for this annotation

GitHub Actions / E2E for 'Local'

[chromium] › e2e/pages/table.download-manager.base.spec.ts:9:5 › Download manager: downloaded file should be equal to ideal

1) [chromium] › e2e/pages/table.download-manager.base.spec.ts:9:5 › Download manager: downloaded file should be equal to ideal Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Test timeout of 10000ms exceeded.

Check failure on line 1 in packages/ui/tests/e2e/pages/table.download-manager.base.spec.ts

View workflow job for this annotation

GitHub Actions / E2E for 'Local'

[chromium] › e2e/pages/table.download-manager.base.spec.ts:9:5 › Download manager: downloaded file should be equal to ideal

1) [chromium] › e2e/pages/table.download-manager.base.spec.ts:9:5 › Download manager: downloaded file should be equal to ideal Retry #2 ─────────────────────────────────────────────────────────────────────────────────────── Test timeout of 10000ms exceeded.
import fs from 'fs';
import crypto from 'crypto';

Expand All @@ -17,18 +17,25 @@
await downloadButton.waitFor();
await downloadButton.click();

const downloadButtonModal = page.locator('[data-qa="download-static-table"]');
const downloadButtonModal = page.getByTestId('download-static-table');
await downloadButtonModal.waitFor();

const downloadPromise = page.waitForEvent('download');

Check failure on line 23 in packages/ui/tests/e2e/pages/table.download-manager.base.spec.ts

View workflow job for this annotation

GitHub Actions / E2E for 'Local'

[chromium] › e2e/pages/table.download-manager.base.spec.ts:9:5 › Download manager: downloaded file should be equal to ideal

1) [chromium] › e2e/pages/table.download-manager.base.spec.ts:9:5 › Download manager: downloaded file should be equal to ideal Error: page.waitForEvent: Test timeout of 10000ms exceeded. =========================== logs =========================== waiting for event "download" ============================================================ 21 | await downloadButtonModal.waitFor(); 22 | > 23 | const downloadPromise = page.waitForEvent('download'); | ^ 24 | await downloadButtonModal.click(); 25 | 26 | const download = await downloadPromise; at /actions-runner/_work/ytsaurus-ui/ytsaurus-ui/packages/ui/tests/e2e/pages/table.download-manager.base.spec.ts:23:34

Check failure on line 23 in packages/ui/tests/e2e/pages/table.download-manager.base.spec.ts

View workflow job for this annotation

GitHub Actions / E2E for 'Local'

[chromium] › e2e/pages/table.download-manager.base.spec.ts:9:5 › Download manager: downloaded file should be equal to ideal

1) [chromium] › e2e/pages/table.download-manager.base.spec.ts:9:5 › Download manager: downloaded file should be equal to ideal Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: page.waitForEvent: Test timeout of 10000ms exceeded. =========================== logs =========================== waiting for event "download" ============================================================ 21 | await downloadButtonModal.waitFor(); 22 | > 23 | const downloadPromise = page.waitForEvent('download'); | ^ 24 | await downloadButtonModal.click(); 25 | 26 | const download = await downloadPromise; at /actions-runner/_work/ytsaurus-ui/ytsaurus-ui/packages/ui/tests/e2e/pages/table.download-manager.base.spec.ts:23:34

Check failure on line 23 in packages/ui/tests/e2e/pages/table.download-manager.base.spec.ts

View workflow job for this annotation

GitHub Actions / E2E for 'Local'

[chromium] › e2e/pages/table.download-manager.base.spec.ts:9:5 › Download manager: downloaded file should be equal to ideal

1) [chromium] › e2e/pages/table.download-manager.base.spec.ts:9:5 › Download manager: downloaded file should be equal to ideal Retry #2 ─────────────────────────────────────────────────────────────────────────────────────── Error: page.waitForEvent: Test timeout of 10000ms exceeded. =========================== logs =========================== waiting for event "download" ============================================================ 21 | await downloadButtonModal.waitFor(); 22 | > 23 | const downloadPromise = page.waitForEvent('download'); | ^ 24 | await downloadButtonModal.click(); 25 | 26 | const download = await downloadPromise; at /actions-runner/_work/ytsaurus-ui/ytsaurus-ui/packages/ui/tests/e2e/pages/table.download-manager.base.spec.ts:23:34
await downloadButtonModal.click();

page.on('download', async (download) => {
const destination = './downloads/' + download.suggestedFilename();
await download.saveAs(destination);

const fileHash = getFileHash(destination);
const idealFileHash = getFileHash('./data/static-table/static-table');
expect(fileHash).toEqual(idealFileHash);
});
const download = await downloadPromise;

const toastTitle = page.locator('.g-toast__title');
await toastTitle.waitFor();
const text = await toastTitle.innerText();
expect(text).toBe('Success');

const destination = './downloads/' + download.suggestedFilename();
await download.saveAs(destination);

const fileHash = getFileHash(destination);
const idealFileHash = getFileHash('./data/static-table/static-table');
expect(fileHash).toEqual(idealFileHash);
});

function getFileHash(filePath: string) {
Expand Down
34 changes: 19 additions & 15 deletions packages/ui/tests/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/ui/tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@
"license": "ISC",
"private": true,
"devDependencies": {
"@playwright/test": "^1.44.1"
"@playwright/test": "^1.50.1"
}
}
Loading