DEP: fix remaining incompatibilities and declare compatibility with unyt 3.0 #4724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
added
dependencies
neutrinoceros
changed the title
|
Looks like we're still having a couple incompatibilities, I'll work out the ones that can be addressed here and solve the rest of them upstream, if any. |
3 tasks
|
@yt-fido Test this please |
neutrinoceros
force-pushed
the
accept_unyt_3
branch
from
0779aa6 to
338c955
Compare
|
Okay I got one successful run using a patched version of unyt 3.0.0. Here are all upstream patches
I think I'll yank 3.0.0 from PyPI if @jzuhone agrees, but 3.0.1 will be compatible for sure |
…nComparison.compare_dobj_selection
neutrinoceros
force-pushed
the
accept_unyt_3
branch
from
338c955 to
12d2124
Compare
|
@yt-fido test this please |
|
Ok, all set ! |
jzuhone
approved these changes
Nov 2, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/yt
that referenced
this pull request
Nov 3, 2023
… declare compatibility with unyt 3.0
neutrinoceros
added a commit
that referenced
this pull request
Nov 4, 2023
…4-on-yt-4.3.x Backport PR #4724 on branch yt-4.3.x (DEP: fix remaining incompatibilities and declare compatibility with unyt 3.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
closes #4162 now that unyt 3.0 is available on PyPI