BUG: fix caching error with UnitRegistry.modify #476
Conversation
neutrinoceros
force-pushed
the
hotfix_registry_cache_error
branch
2 times, most recently
from
5bf52c5 to
99cf350
Compare
neutrinoceros
force-pushed
the
hotfix_registry_cache_error
branch
from
2aee0fc to
d8b8e91
Compare
unyt/tests/test_unit_registry.py
Outdated
| u2 = Unit("celery", registry=ureg) | ||
| assert 1.0 * u2 == 0.5 * u0 | ||
|
|
||
| # TODO: test behaviour in u1 pre/post modification |
There was a problem hiding this comment.
this line refers to the Unit created on after u0 (I guess linters removed the variable binding to u1 because I didn't use it). The behaviour I'm getting with the branch at the moment is that the Unit object created before ureg.modify still uses the original base value even after modification of the registry. This seems to be in line with @AdamCohan's expectations, and seems consistent with the idea that Unit objects should be immutable, but I don't think that this case is currently tested. @jzuhone, what should be the expected behaviour in your opinion ?
There was a problem hiding this comment.
Let's try that again: @jzuhone
There was a problem hiding this comment.
The behavior you are seeing is correct.
There was a problem hiding this comment.
thank you ! I've updated the test to reflect this and rebased the branch, this is now ready for review !
neutrinoceros
force-pushed
the
hotfix_registry_cache_error
branch
from
24c7864 to
0f62901
Compare
close #473