Fix NULL dereference when refreshing window leader with an inconsistent wm tree #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the wm tree is not consistent, there might be certain updates we can't do (e.g. refreshing window leaders). So once the wm tree becomes consistent we should retry. Signed-off-by: Yuxuan Shui <[email protected]>
The leader nodes referenced might not be in the tree yet. Fixes #1336 Signed-off-by: Yuxuan Shui <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #1337 +/- ##
==========================================
- Coverage 53.78% 53.72% -0.06%
==========================================
Files 70 70
Lines 15195 15206 +11
==========================================
- Hits 8173 8170 -3
- Misses 7022 7036 +14
|
Yes, it does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #1336
@Monsterovich can you test if this fixes the problem for you?