NO WINDOW LEFT BEHIND #1273
Merged
NO WINDOW LEFT BEHIND #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshui
force-pushed
the
wm-tree
branch
3 times, most recently
from
cafa424
to
13ba96f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #1273 +/- ##
==========================================
+ Coverage 51.55% 51.68% +0.12%
==========================================
Files 62 64 +2
Lines 13347 13567 +220
==========================================
+ Hits 6881 7012 +131
- Misses 6466 6555 +89
|
yshui
force-pushed
the
wm-tree
branch
6 times, most recently
from
fb1bef7
to
e870fda
Compare
|
Update: kind of redesigned how windows are imported into the tree. The inherent racy-ness of X11 protocol really fucked this over. (don't know if you can tell, but I am not happy with this code). This comment goes into a bit more detail about what's going on. |
yshui
force-pushed
the
wm-tree
branch
6 times, most recently
from
6b39b1c
to
afb7b8d
Compare
Signed-off-by: Yuxuan Shui <[email protected]>
yshui
force-pushed
the
wm-tree
branch
2 times, most recently
from
5e44044
to
bd9bb8e
Compare
To let it process some events to validate that it is working. The output of wm_tree is not yet used besides debugging logs. Note because we don't quite setup event subscription the way wm_tree expects, there will be some errors logged, which is normal. Signed-off-by: Yuxuan Shui <[email protected]>
Because wm_tree tracks the entire window tree, it's able to replace several old data structures we used to track windows: the window hash table, the window stack, and the subwin table. So we got rid of those, and fully switched to wm_tree. Fixes window rules for window managers that don't put client window directly under toplevel windows. This includes, according to people's reports, at least i3 and KDE. Fixed a couple small bugs: * dbus was returning window ID as a boolean. * window frame extents not cleared after its client window disappears. Signed-off-by: Yuxuan Shui <[email protected]>
Signed-off-by: Yuxuan Shui <[email protected]>
|
Fixed a use after free, when an incomplete import is deleted before we can completely import it. |
Signed-off-by: Yuxuan Shui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track the entire window tree. Fix window rules for WMs like i3, KDE.