Support plugins #1266
Merged
Support plugins #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshui
force-pushed
the
plugins
branch
4 times, most recently
from
dfc5630
to
9b87c8f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #1266 +/- ##
==========================================
- Coverage 51.64% 51.63% -0.02%
==========================================
Files 59 59
Lines 13236 13349 +113
==========================================
+ Hits 6836 6893 +57
- Misses 6400 6456 +56
|
yshui
force-pushed
the
plugins
branch
3 times, most recently
from
1d52f0d
to
fcfa63e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #1266 +/- ##
==========================================
- Coverage 51.63% 51.52% -0.12%
==========================================
Files 59 60 +1
Lines 13236 13400 +164
==========================================
+ Hits 6835 6904 +69
- Misses 6401 6496 +95
|
Otherwise epoxy will fail with assertion error. Signed-off-by: Yuxuan Shui <[email protected]>
yshui
force-pushed
the
plugins
branch
9 times, most recently
from
829bd5b
to
710ebef
Compare
Instead of a fixed table, allow an arbitrary number of backends to be registered through `backend_register`. Slightly refactored configuration validation. As a side-effect, you now have to explicitly specify a backend, because due to the dynamic nature of backends, there is no way to choose a default. Signed-off-by: Yuxuan Shui <[email protected]>
Signed-off-by: Yuxuan Shui <[email protected]>
It's unclear which functions a custom backend will need, let's be conversative first. Signed-off-by: Yuxuan Shui <[email protected]>
And add a pkgconfig file so they can be found. Signed-off-by: Yuxuan Shui <[email protected]>
We want to change the backend interface as little as possible once we release it as a public interface, so while we still can, we should try to give it maximum flexibility. Signed-off-by: Yuxuan Shui <[email protected]>
Signed-off-by: Yuxuan Shui <[email protected]>
Allow loaded plugins to hook into specific backends. Signed-off-by: Yuxuan Shui <[email protected]>
Signed-off-by: Yuxuan Shui <[email protected]>
The idea is to allow backend plugins to override backend functions by modifying this table. Right now, when they do this they are actually changing a global variable and their change will persist after backend resets (!). Store the table inside backend_base solves this problem. Signed-off-by: Yuxuan Shui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.