various fixes #1242
Merged
various fixes #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid breaking custom animated shaders by having to specify it themselves.
mimic the normal rendering routine by setting ps->render_queued to true before setting and starting the draw timer.
the draw timer has to be stopped before calling the draw_callback_impl function because when there's a custom animated shader it calls the queue_redraw funtion that calls the schedule_render function that sets and starts the draw timer that gets immediately stopped otherwise. this fixes the screen not being redirected back with unredir-if-possible and a custom animated shader and only the first frame being drawn with vsync, no-frame-pacing and a custom animated shader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backend/gl: specify the time uniform location in blit_shader_glsl
to avoid breaking custom animated shaders by having to specify it
themselves.
picom: fix the benchmark option
mimic the normal rendering routine by setting ps->render_queued to true
before setting and starting the draw timer.
picom: fix custom animated shaders
the draw timer has to be stopped before calling the draw_callback_impl
function because when there's a custom animated shader it calls the
queue_redraw funtion that calls the schedule_render function that sets
and starts the draw timer that gets immediately stopped otherwise.
this fixes the screen not being redirected back with unredir-if-possible
and a custom animated shader and only the first frame being drawn with
vsync, no-frame-pacing and a custom animated shader.